hmland: handle commands spanning packet-boundaries

[hmcfgusb] / hmland.c

diff --git a/hmland.c b/hmland.c
index fd2d09e4881c60c4f739e68282c028ebb06272b1..fb6f6309ffd28a1193a085bce7fcf67cfec27415 100644 (file)
--- a/hmland.c
+++ b/hmland.c
@@ -1,6 +1,6 @@
 /* HM-CFG-LAN emulation for HM-CFG-USB
  *
 /* HM-CFG-LAN emulation for HM-CFG-USB
  *

- * Copyright (c) 2013 Michael Gernoth <michael@gernoth.net>
+ * Copyright (c) 2013-15 Michael Gernoth <michael@gernoth.net>

  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to


@@ -25,6 +25,7 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdint.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdint.h>

+#include <stdarg.h>

 #include <string.h>
 #include <strings.h>
 #include <poll.h>
 #include <string.h>
 #include <strings.h>
 #include <poll.h>


@@ -46,15 +47,23 @@
 #define PID_FILE "/var/run/hmland.pid"
 
 #define DEFAULT_REBOOT_SECONDS 86400
 #define PID_FILE "/var/run/hmland.pid"
 
 #define DEFAULT_REBOOT_SECONDS 86400

+#define LAN_READ_CHUNK_SIZE    2048
+/* Don't allow remote clients to consume all of our memory */
+#define LAN_MAX_LINE_LENGTH    4096
+#define LAN_MAX_BUF_LENGTH     1048576

 
 extern char *optarg;
 
 static int impersonate_hmlanif = 0;
 static int debug = 0;
 static int verbose = 0;
 
 extern char *optarg;
 
 static int impersonate_hmlanif = 0;
 static int debug = 0;
 static int verbose = 0;

+static FILE *logfile = NULL;

 static int reboot_seconds = 0;
 static int reboot_at_hour = -1;
 static int reboot_at_minute = -1;
 static int reboot_seconds = 0;
 static int reboot_at_hour = -1;
 static int reboot_at_minute = -1;

+static int reboot_set = 0;
+static uint8_t *lan_read_buf = NULL;
+static int lan_read_buflen = 0;

 
 struct queued_rx {
        char *rx;
 
 struct queued_rx {
        char *rx;


@@ -88,6 +97,48 @@ static void print_timestamp(FILE *f)
        fprintf(f, "%s.%06ld: ", ts, tv.tv_usec);
 }
 
        fprintf(f, "%s.%06ld: ", ts, tv.tv_usec);
 }
 

+static void write_log(char *buf, int len, char *fmt, ...)
+{
+       va_list ap;
+       int i;
+
+       if ((!logfile) && (!verbose))
+               return;
+
+       if (logfile)
+               print_timestamp(logfile);
+       if (verbose)
+               print_timestamp(stdout);
+
+       if (fmt) {
+               if (logfile) {
+                       va_start(ap, fmt);
+                       vfprintf(logfile, fmt, ap);
+                       va_end(ap);
+               }
+               if (verbose) {
+                       va_start(ap, fmt);
+                       vprintf(fmt, ap);
+                       va_end(ap);
+               }
+       }
+
+       if (buf && len) {
+               for (i = 0; i < len; i++) {
+                       if (logfile)
+                               fprintf(logfile, "%c", buf[i]);
+                       if (verbose)
+                               printf("%c", buf[i]);
+               }
+               if (logfile)
+                       fprintf(logfile, "\n");
+               if (verbose)
+                       printf("\n");
+       }
+       if (logfile)
+               fflush(logfile);
+}
+

 static int format_part_out(uint8_t **inpos, int inlen, uint8_t **outpos, int outlen, int len, int flags)
 {
        const uint8_t nibble[16] = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
 static int format_part_out(uint8_t **inpos, int inlen, uint8_t **outpos, int outlen, int len, int flags)
 {
        const uint8_t nibble[16] = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',


@@ -211,6 +262,7 @@ static int hmlan_format_out(uint8_t *buf, int buf_len, void *data)
        uint8_t out[1024];
        uint8_t *outpos;
        uint8_t *inpos;
        uint8_t out[1024];
        uint8_t *outpos;
        uint8_t *inpos;

+       uint16_t version;

        int fd = *((int*)data);
        int w;
 
        int fd = *((int*)data);
        int w;
 


@@ -230,6 +282,8 @@ static int hmlan_format_out(uint8_t *buf, int buf_len, void *data)
                                buf[7] = 'N';
                        }
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 0, FLAG_LENGTH_BYTE);
                                buf[7] = 'N';
                        }
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 0, FLAG_LENGTH_BYTE);

+                       version = inpos[0] << 8;
+                       version |= inpos[1];

                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 2, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE);
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 0, FLAG_COMMA_BEFORE | FLAG_LENGTH_BYTE);
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 3, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE);
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 2, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE);
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 0, FLAG_COMMA_BEFORE | FLAG_LENGTH_BYTE);
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 3, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE);


@@ -237,6 +291,22 @@ static int hmlan_format_out(uint8_t *buf, int buf_len, void *data)
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 4, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE);
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 2, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE | FLAG_NL);
 
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 4, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE);
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 2, FLAG_FORMAT_HEX | FLAG_COMMA_BEFORE | FLAG_NL);
 

+                       if (!reboot_set) {
+                               int new_reboot_seconds;
+
+                               if (version < 0x03c7) {
+                                       new_reboot_seconds = DEFAULT_REBOOT_SECONDS;
+                               } else {
+                                       new_reboot_seconds = 0;
+                               }
+
+                               if (verbose && new_reboot_seconds && (reboot_seconds != new_reboot_seconds))
+                                       printf("Rebooting in %u seconds due to old firmware (0.%d)\n",
+                                               new_reboot_seconds, version);
+
+                               reboot_seconds = new_reboot_seconds;
+                       }
+

                        break;
                case 'E':
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 3, FLAG_FORMAT_HEX);
                        break;
                case 'E':
                        format_part_out(&inpos, (buf_len-(inpos-buf)), &outpos, (sizeof(out)-(outpos-out)), 3, FLAG_FORMAT_HEX);


@@ -299,15 +369,7 @@ static int hmlan_format_out(uint8_t *buf, int buf_len, void *data)
                return 1;
        }
 
                return 1;
        }
 

-       if (verbose) {
-               int i;
-
-               print_timestamp(stdout);
-               printf("LAN < ");
-               for (i = 0; i < outpos-out-2; i++)
-                       printf("%c", out[i]);
-               printf("\n");
-       }
+       write_log((char*)out, outpos-out-2, "LAN < ");

 
        w = write(fd, out, outpos-out);
        if (w <= 0) {
 
        w = write(fd, out, outpos-out);
        if (w <= 0) {


@@ -321,15 +383,7 @@ static int hmlan_format_out(uint8_t *buf, int buf_len, void *data)
                struct queued_rx *last_rx;
 
                while (curr_rx) {
                struct queued_rx *last_rx;
 
                while (curr_rx) {

-                       if (verbose) {
-                               int i;
-
-                               print_timestamp(stdout);
-                               printf("LAN < ");
-                               for (i = 0; i < curr_rx->len-2; i++)
-                                       printf("%c", curr_rx->rx[i]);
-                               printf("\n");
-                       }
+                       write_log(curr_rx->rx, curr_rx->len-2, "LAN < ");

 
                        w = write(fd, curr_rx->rx, curr_rx->len);
                        if (w <= 0) {
 
                        w = write(fd, curr_rx->rx, curr_rx->len);
                        if (w <= 0) {


@@ -350,78 +404,93 @@ static int hmlan_format_out(uint8_t *buf, int buf_len, void *data)
        return 1;
 }
 
        return 1;
 }
 

-static int hmlan_parse_in(int fd, void *data)
+static int hmlan_parse_one(uint8_t *cmd, int last, void *data)

 {
        struct hmcfgusb_dev *dev = data;
 {
        struct hmcfgusb_dev *dev = data;

-       uint8_t buf[1025];

        uint8_t out[0x40]; //FIXME!!!
        uint8_t *outpos;
        uint8_t out[0x40]; //FIXME!!!
        uint8_t *outpos;

-       uint8_t *inpos;
-       int i;
-       int last;
-       int r;
+       uint8_t *inpos = cmd;

 
 

-       memset(buf, 0, sizeof(buf));
+       outpos = out;

 
 

-       r = read(fd, buf, sizeof(buf)-1);
-       if (r > 0) {
-               uint8_t *inend = buf + r;
+       if (last == 0)
+               return 1;

 
 

-               inpos = buf;
+       write_log((char*)cmd, last,  "LAN > ");
+
+       memset(out, 0, sizeof(out));
+       *outpos++ = *inpos++;
+
+       switch(*cmd) {
+               case 'S':
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0);
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0);
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0);
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0);
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0);
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), FLAG_LENGTH_BYTE);
+                       break;
+               case 'Y':
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0);
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), 0);
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), FLAG_LENGTH_BYTE);
+                       break;
+               default:
+                       parse_part_in(&inpos, (last-(inpos-cmd)), &outpos, (sizeof(out)-(outpos-out)), FLAG_IGNORE_COMMAS);
+                       break;
+       }

 
 

-               while (inpos < inend) {
-                       uint8_t *instart = inpos;
+       hmcfgusb_send(dev, out, sizeof(out), 1);

 
 

-                       if ((*inpos == '\r') || (*inpos == '\n')) {
-                               inpos++;
-                               continue;
-                       }
-                       
-                       outpos = out;
+       return 1;
+}

 
 

-                       last = inend - inpos;
+static int hmlan_parse_in(int fd, void *data)
+{
+       uint8_t *newbuf;
+       int r;
+       int i;

 
 

-                       for (i = 0; i < last; i++) {
-                               if ((inpos[i] == '\r') || (inpos[i] == '\n')) {
-                                       last = i;
+       newbuf = realloc(lan_read_buf, lan_read_buflen + LAN_READ_CHUNK_SIZE);
+       if (!newbuf) {
+               perror("realloc");
+               return 0;
+       }
+       lan_read_buf = newbuf;
+       r = read(fd, lan_read_buf + lan_read_buflen, LAN_READ_CHUNK_SIZE);
+       if (r > 0) {
+               lan_read_buflen += r;
+               if (lan_read_buflen > LAN_MAX_BUF_LENGTH) {
+                       if (verbose)
+                               printf("Our buffer is bigger than %d bytes (%d bytes), closing connection!\n", LAN_MAX_BUF_LENGTH, lan_read_buflen);
+                       return -1;
+               }
+               while(lan_read_buflen > 0) {
+                       int found = 0;
+
+                       for (i = 0; i < lan_read_buflen; i++) {
+                               if ((lan_read_buf[i] == '\r') || (lan_read_buf[i] == '\n')) {
+                                       if (i > 0)
+                                               hmlan_parse_one(lan_read_buf, i, data);
+                                       memmove(lan_read_buf, lan_read_buf + i + 1, lan_read_buflen - (i + 1));
+                                       lan_read_buflen -= (i + 1);
+                                       found = 1;

                                        break;
                                }
                                        break;
                                }

+                               if (i > LAN_MAX_LINE_LENGTH) {
+                                       if (verbose)
+                                               printf("Client sent more than %d bytes without newline, closing connection!\n", LAN_MAX_LINE_LENGTH);
+                                       return -1;
+                               }

                        }
                        }

-
-                       if (last == 0)
-                               continue;
-
-                       if (verbose) {
-                               print_timestamp(stdout);
-                               printf("LAN > ");
-                               for (i = 0; i < last; i++)
-                                       printf("%c", instart[i]);
-                               printf("\n");
-                       }
-
-                       memset(out, 0, sizeof(out));
-                       *outpos++ = *inpos++;
-
-                       switch(*instart) {
-                               case 'S':
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), 0);
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), 0);
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), 0);
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), 0);
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), 0);
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), FLAG_LENGTH_BYTE);
-                                       break;
-                               case 'Y':
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), 0);
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), 0);
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), FLAG_LENGTH_BYTE);
-                                       break;
-                               default:
-                                       parse_part_in(&inpos, (last-(inpos-instart)), &outpos, (sizeof(out)-(outpos-out)), FLAG_IGNORE_COMMAS);
-                                       break;
+                       if (!found)
+                               break;
+                       newbuf = realloc(lan_read_buf, lan_read_buflen);
+                       if (lan_read_buflen && !newbuf) {
+                               perror("realloc");
+                               return 0;

                        }
                        }

-
-                       hmcfgusb_send(dev, out, sizeof(out), 1);
+                       lan_read_buf = newbuf;

                }
        } else if (r < 0) {
                if (errno != ECONNRESET)
                }
        } else if (r < 0) {
                if (errno != ECONNRESET)


@@ -508,7 +577,7 @@ static int comm(int fd_in, int fd_out, int master_socket, int flags)
        while(!quit) {
                int fd;
 
        while(!quit) {
                int fd;
 

-               fd = hmcfgusb_poll(dev, 1);     /* Wakeup device/bus at least once a second */
+               fd = hmcfgusb_poll(dev, 1000);  /* Wakeup device/bus at least once a second */

                if (fd >= 0) {
                        if (fd == master_socket) {
                                int client;
                if (fd >= 0) {
                        if (fd == master_socket) {
                                int client;


@@ -697,28 +766,27 @@ static int socket_server(char *iface, int port, int flags)
                /* FIXME: getnameinfo... */
                client_addr = ntohl(csin.sin_addr.s_addr);
 
                /* FIXME: getnameinfo... */
                client_addr = ntohl(csin.sin_addr.s_addr);
 

-               if (verbose) {
-                       print_timestamp(stdout);
-                       printf("Client %d.%d.%d.%d connected!\n",
-                                       (client_addr & 0xff000000) >> 24,
-                                       (client_addr & 0x00ff0000) >> 16,
-                                       (client_addr & 0x0000ff00) >> 8,
-                                       (client_addr & 0x000000ff));
-               }
+               write_log(NULL, 0, "Client %d.%d.%d.%d connected!\n",
+                               (client_addr & 0xff000000) >> 24,
+                               (client_addr & 0x00ff0000) >> 16,
+                               (client_addr & 0x0000ff00) >> 8,
+                               (client_addr & 0x000000ff));

 
                comm(client, client, sock, flags);
 
                shutdown(client, SHUT_RDWR);
                close(client);
 
 
                comm(client, client, sock, flags);
 
                shutdown(client, SHUT_RDWR);
                close(client);
 

-               if (verbose) {
-                       print_timestamp(stdout);
-                       printf("Connection to %d.%d.%d.%d closed!\n",
-                                       (client_addr & 0xff000000) >> 24,
-                                       (client_addr & 0x00ff0000) >> 16,
-                                       (client_addr & 0x0000ff00) >> 8,
-                                       (client_addr & 0x000000ff));
-               }
+               if (lan_read_buf)
+                       free(lan_read_buf);
+               lan_read_buf = NULL;
+               lan_read_buflen = 0;
+
+               write_log(NULL, 0, "Connection to %d.%d.%d.%d closed!\n",
+                               (client_addr & 0xff000000) >> 24,
+                               (client_addr & 0x00ff0000) >> 16,
+                               (client_addr & 0x0000ff00) >> 8,
+                               (client_addr & 0x000000ff));

                sleep(1);
        }
 
                sleep(1);
        }
 


@@ -742,9 +810,10 @@ void hmlan_syntax(char *prog)
        fprintf(stderr, "\t-h\t\tthis help\n");
        fprintf(stderr, "\t-i\t\tinteractive mode (connect HM-CFG-USB to terminal)\n");
        fprintf(stderr, "\t-l ip\t\tlisten on given IP address only (for example 127.0.0.1)\n");
        fprintf(stderr, "\t-h\t\tthis help\n");
        fprintf(stderr, "\t-i\t\tinteractive mode (connect HM-CFG-USB to terminal)\n");
        fprintf(stderr, "\t-l ip\t\tlisten on given IP address only (for example 127.0.0.1)\n");

+       fprintf(stderr, "\t-L logfile\tlog network-communication to logfile\n");

        fprintf(stderr, "\t-P\t\tcreate PID file " PID_FILE " in daemon mode\n");
        fprintf(stderr, "\t-p n\t\tlisten on port n (default: 1000)\n");
        fprintf(stderr, "\t-P\t\tcreate PID file " PID_FILE " in daemon mode\n");
        fprintf(stderr, "\t-p n\t\tlisten on port n (default: 1000)\n");

-       fprintf(stderr, "\t-r n\t\treboot HM-CFG-USB after n seconds (0: no reboot, default: %u)\n", DEFAULT_REBOOT_SECONDS);
+       fprintf(stderr, "\t-r n\t\treboot HM-CFG-USB after n seconds (0: no reboot, default: %u if FW < 0.967, 0 otherwise)\n", DEFAULT_REBOOT_SECONDS);

        fprintf(stderr, "\t   hh:mm\treboot HM-CFG-USB daily at hh:mm\n");
        fprintf(stderr, "\t-v\t\tverbose mode\n");
        fprintf(stderr, "\t-V\t\tshow version (" VERSION ")\n");
        fprintf(stderr, "\t   hh:mm\treboot HM-CFG-USB daily at hh:mm\n");
        fprintf(stderr, "\t-v\t\tverbose mode\n");
        fprintf(stderr, "\t-V\t\tshow version (" VERSION ")\n");


@@ -760,9 +829,7 @@ int main(int argc, char **argv)
        char *ep;
        int opt;
        
        char *ep;
        int opt;
        

-       reboot_seconds = DEFAULT_REBOOT_SECONDS;
-
-       while((opt = getopt(argc, argv, "DdhiPp:Rr:l:vV")) != -1) {
+       while((opt = getopt(argc, argv, "DdhiPp:Rr:l:L:vV")) != -1) {

                switch (opt) {
                        case 'D':
                                debug = 1;
                switch (opt) {
                        case 'D':
                                debug = 1;


@@ -805,10 +872,18 @@ int main(int argc, char **argv)
                                                exit(EXIT_FAILURE);
                                        }
                                }
                                                exit(EXIT_FAILURE);
                                        }
                                }

+                               reboot_set = 1;

                                break;
                        case 'l':
                                iface = optarg;
                                break;
                                break;
                        case 'l':
                                iface = optarg;
                                break;

+                       case 'L':
+                               logfile = fopen(optarg, "a");
+                               if (!logfile) {
+                                       perror("fopen(logfile)");
+                                       exit(EXIT_FAILURE);
+                               }
+                               break;

                        case 'v':
                                verbose = 1;
                                break;
                        case 'v':
                                verbose = 1;
                                break;