cvs.zerfleddert.de Git - proxmark3-svn/blobdiff

diff --git a/client/cmdhfmf.c b/client/cmdhfmf.c

index 54c5fc87788192c3ad7936e1de36bc818ce17435..eb3dc878f15adc79fcd3349d96ef00824b2e0916 100644 (file)

--- a/client/cmdhfmf.c

+++ b/client/cmdhfmf.c

@@ -9,8 +9,18 @@

//-----------------------------------------------------------------------------\r

\r

#include <inttypes.h>\r

-#include "cmdhfmf.h"\r

-#include "./nonce2key/nonce2key.h"\r

+#include <stdio.h>\r

+#include <stdlib.h>\r

+#include "proxmark3.h"\r

+#include "cmdmain.h"\r

+#include "util.h"\r

+#include "ui.h"\r

+#include "mifarehost.h"\r

+#include "mifare.h"\r

+#include "nonce2key/nonce2key.h"\r

+\r

+#define NESTED_SECTOR_RETRY 10 // how often we try mfested() until we give up\r

+\r

\r

static int CmdHelp(const char *Cmd);\r

\r

@@ -35,8 +45,10 @@ int CmdHF14AMifare(const char *Cmd)

SendCommand(&c);\r

\r

//flush queue\r

- while (ukbhit()) getchar();\r

-\r

+ while (ukbhit()) {\r

+ int c = getchar(); (void) c;\r

+ }\r

+ \r

// wait cycle\r

while (true) {\r

printf(".");\r

@@ -303,7 +315,8 @@ int CmdHF14AMfDump(const char *Cmd)

\r

// Read keys A from file\r

for (sectorNo=0; sectorNo<numSectors; sectorNo++) {\r

- if (fread( keyA[sectorNo], 1, 6, fin ) == 0) {\r

+ size_t bytes_read = fread(keyA[sectorNo], 1, 6, fin);\r

+ if (bytes_read != 6) {\r

PrintAndLog("File reading error.");\r

fclose(fin);\r

return 2;\r

@@ -312,7 +325,8 @@ int CmdHF14AMfDump(const char *Cmd)

\r

// Read keys B from file\r

for (sectorNo=0; sectorNo<numSectors; sectorNo++) {\r

- if (fread( keyB[sectorNo], 1, 6, fin ) == 0) {\r

+ size_t bytes_read = fread(keyB[sectorNo], 1, 6, fin);\r

+ if (bytes_read != 6) {\r

PrintAndLog("File reading error.");\r

fclose(fin);\r

return 2;\r

@@ -324,29 +338,32 @@ int CmdHF14AMfDump(const char *Cmd)

PrintAndLog("|-----------------------------------------|");\r

PrintAndLog("|------ Reading sector access bits...-----|");\r

PrintAndLog("|-----------------------------------------|");\r

- \r

+ uint8_t tries = 0;\r

for (sectorNo = 0; sectorNo < numSectors; sectorNo++) {\r

- UsbCommand c = {CMD_MIFARE_READBL, {FirstBlockOfSector(sectorNo) + NumBlocksPerSector(sectorNo) - 1, 0, 0}};\r

- memcpy(c.d.asBytes, keyA[sectorNo], 6);\r

- SendCommand(&c);\r

+ for (tries = 0; tries < 3; tries++) { \r

+ UsbCommand c = {CMD_MIFARE_READBL, {FirstBlockOfSector(sectorNo) + NumBlocksPerSector(sectorNo) - 1, 0, 0}};\r

+ memcpy(c.d.asBytes, keyA[sectorNo], 6);\r

+ SendCommand(&c);\r

\r

- if (WaitForResponseTimeout(CMD_ACK,&resp,1500)) {\r

- uint8_t isOK = resp.arg[0] & 0xff;\r

- uint8_t *data = resp.d.asBytes;\r

- if (isOK){\r

- rights[sectorNo][0] = ((data[7] & 0x10)>>2) | ((data[8] & 0x1)<<1) | ((data[8] & 0x10)>>4); // C1C2C3 for data area 0\r

- rights[sectorNo][1] = ((data[7] & 0x20)>>3) | ((data[8] & 0x2)<<0) | ((data[8] & 0x20)>>5); // C1C2C3 for data area 1\r

- rights[sectorNo][2] = ((data[7] & 0x40)>>4) | ((data[8] & 0x4)>>1) | ((data[8] & 0x40)>>6); // C1C2C3 for data area 2\r

- rights[sectorNo][3] = ((data[7] & 0x80)>>5) | ((data[8] & 0x8)>>2) | ((data[8] & 0x80)>>7); // C1C2C3 for sector trailer\r

+ if (WaitForResponseTimeout(CMD_ACK,&resp,1500)) {\r

+ uint8_t isOK = resp.arg[0] & 0xff;\r

+ uint8_t *data = resp.d.asBytes;\r

+ if (isOK){\r

+ rights[sectorNo][0] = ((data[7] & 0x10)>>2) | ((data[8] & 0x1)<<1) | ((data[8] & 0x10)>>4); // C1C2C3 for data area 0\r

+ rights[sectorNo][1] = ((data[7] & 0x20)>>3) | ((data[8] & 0x2)<<0) | ((data[8] & 0x20)>>5); // C1C2C3 for data area 1\r

+ rights[sectorNo][2] = ((data[7] & 0x40)>>4) | ((data[8] & 0x4)>>1) | ((data[8] & 0x40)>>6); // C1C2C3 for data area 2\r

+ rights[sectorNo][3] = ((data[7] & 0x80)>>5) | ((data[8] & 0x8)>>2) | ((data[8] & 0x80)>>7); // C1C2C3 for sector trailer\r

+ break;\r

+ } else if (tries == 2) { // on last try set defaults\r

+ PrintAndLog("Could not get access rights for sector %2d. Trying with defaults...", sectorNo);\r

+ rights[sectorNo][0] = rights[sectorNo][1] = rights[sectorNo][2] = 0x00;\r

+ rights[sectorNo][3] = 0x01;\r

+ }\r

} else {\r

- PrintAndLog("Could not get access rights for sector %2d. Trying with defaults...", sectorNo);\r

+ PrintAndLog("Command execute timeout when trying to read access rights for sector %2d. Trying with defaults...", sectorNo);\r

rights[sectorNo][0] = rights[sectorNo][1] = rights[sectorNo][2] = 0x00;\r

rights[sectorNo][3] = 0x01;\r

}\r

- } else {\r

- PrintAndLog("Command execute timeout when trying to read access rights for sector %2d. Trying with defaults...", sectorNo);\r

- rights[sectorNo][0] = rights[sectorNo][1] = rights[sectorNo][2] = 0x00;\r

- rights[sectorNo][3] = 0x01;\r

}\r

\r

@@ -358,27 +375,33 @@ int CmdHF14AMfDump(const char *Cmd)

for (sectorNo = 0; isOK && sectorNo < numSectors; sectorNo++) {\r

for (blockNo = 0; isOK && blockNo < NumBlocksPerSector(sectorNo); blockNo++) {\r

bool received = false;\r

- \r

- if (blockNo == NumBlocksPerSector(sectorNo) - 1) { // sector trailer. At least the Access Conditions can always be read with key A. \r

- UsbCommand c = {CMD_MIFARE_READBL, {FirstBlockOfSector(sectorNo) + blockNo, 0, 0}};\r

- memcpy(c.d.asBytes, keyA[sectorNo], 6);\r

- SendCommand(&c);\r

- received = WaitForResponseTimeout(CMD_ACK,&resp,1500);\r

- } else { // data block. Check if it can be read with key A or key B\r

- uint8_t data_area = sectorNo<32?blockNo:blockNo/5;\r

- if ((rights[sectorNo][data_area] == 0x03) || (rights[sectorNo][data_area] == 0x05)) { // only key B would work\r

- UsbCommand c = {CMD_MIFARE_READBL, {FirstBlockOfSector(sectorNo) + blockNo, 1, 0}};\r

- memcpy(c.d.asBytes, keyB[sectorNo], 6);\r

- SendCommand(&c);\r

- received = WaitForResponseTimeout(CMD_ACK,&resp,1500);\r

- } else if (rights[sectorNo][data_area] == 0x07) { // no key would work\r

- isOK = false;\r

- PrintAndLog("Access rights do not allow reading of sector %2d block %3d", sectorNo, blockNo);\r

- } else { // key A would work\r

+ for (tries = 0; tries < 3; tries++) { \r

+ if (blockNo == NumBlocksPerSector(sectorNo) - 1) { // sector trailer. At least the Access Conditions can always be read with key A. \r

UsbCommand c = {CMD_MIFARE_READBL, {FirstBlockOfSector(sectorNo) + blockNo, 0, 0}};\r

memcpy(c.d.asBytes, keyA[sectorNo], 6);\r

SendCommand(&c);\r

received = WaitForResponseTimeout(CMD_ACK,&resp,1500);\r

+ } else { // data block. Check if it can be read with key A or key B\r

+ uint8_t data_area = sectorNo<32?blockNo:blockNo/5;\r

+ if ((rights[sectorNo][data_area] == 0x03) || (rights[sectorNo][data_area] == 0x05)) { // only key B would work\r

+ UsbCommand c = {CMD_MIFARE_READBL, {FirstBlockOfSector(sectorNo) + blockNo, 1, 0}};\r

+ memcpy(c.d.asBytes, keyB[sectorNo], 6);\r

+ SendCommand(&c);\r

+ received = WaitForResponseTimeout(CMD_ACK,&resp,1500);\r

+ } else if (rights[sectorNo][data_area] == 0x07) { // no key would work\r

+ isOK = false;\r

+ PrintAndLog("Access rights do not allow reading of sector %2d block %3d", sectorNo, blockNo);\r

+ tries = 2;\r

+ } else { // key A would work\r

+ UsbCommand c = {CMD_MIFARE_READBL, {FirstBlockOfSector(sectorNo) + blockNo, 0, 0}};\r

+ memcpy(c.d.asBytes, keyA[sectorNo], 6);\r

+ SendCommand(&c);\r

+ received = WaitForResponseTimeout(CMD_ACK,&resp,1500);\r

+ }\r

+ if (received) {\r

+ isOK = resp.arg[0] & 0xff;\r

+ if (isOK) break;\r

}\r

\r

@@ -467,16 +490,17 @@ int CmdHF14AMfRestore(const char *Cmd)

}\r

\r

for (sectorNo = 0; sectorNo < numSectors; sectorNo++) {\r

- if (fread(keyA[sectorNo], 1, 6, fkeys) == 0) {\r

+ size_t bytes_read = fread(keyA[sectorNo], 1, 6, fkeys);\r

+ if (bytes_read != 6) {\r

PrintAndLog("File reading error (dumpkeys.bin).");\r

-\r

fclose(fkeys);\r

return 2;\r

}\r

\r

for (sectorNo = 0; sectorNo < numSectors; sectorNo++) {\r

- if (fread(keyB[sectorNo], 1, 6, fkeys) == 0) {\r

+ size_t bytes_read = fread(keyB[sectorNo], 1, 6, fkeys);\r

+ if (bytes_read != 6) {\r

PrintAndLog("File reading error (dumpkeys.bin).");\r

fclose(fkeys);\r

return 2;\r

@@ -496,7 +520,8 @@ int CmdHF14AMfRestore(const char *Cmd)

UsbCommand c = {CMD_MIFARE_WRITEBL, {FirstBlockOfSector(sectorNo) + blockNo, keyType, 0}};\r

memcpy(c.d.asBytes, key, 6);\r

\r

- if (fread(bldata, 1, 16, fdump) == 0) {\r

+ size_t bytes_read = fread(bldata, 1, 16, fdump);\r

+ if (bytes_read != 16) {\r

PrintAndLog("File reading error (dumpdata.bin).");\r

fclose(fdump);\r

return 2;\r

@@ -536,10 +561,17 @@ int CmdHF14AMfRestore(const char *Cmd)

return 0;\r

}\r

\r

+\r

+typedef struct {\r

+ uint64_t Key[2];\r

+ int foundKey[2];\r

+} sector_t;\r

+\r

int CmdHF14AMfNested(const char *Cmd)\r

{\r

int i, j, res, iterations;\r

- sector *e_sector = NULL;\r

+ sector_t *e_sector = NULL;\r

uint8_t blockNo = 0;\r

uint8_t keyType = 0;\r

uint8_t trgBlockNo = 0;\r

@@ -659,7 +691,7 @@ int CmdHF14AMfNested(const char *Cmd)

clock_t time1;\r

time1 = clock();\r

\r

- e_sector = calloc(SectorsCnt, sizeof(sector));\r

+ e_sector = calloc(SectorsCnt, sizeof(sector_t));\r

if (e_sector == NULL) return 1;\r

\r

//test current key and additional standard keys first\r

@@ -920,6 +952,7 @@ int CmdHF14AMfChk(const char *Cmd)

if (!p) {\r

PrintAndLog("Cannot allocate memory for defKeys");\r

free(keyBlock);\r

+ fclose(f);\r

return 2;\r

}\r

keyBlock = p;\r

@@ -1448,7 +1481,7 @@ int CmdHF14AMfELoad(const char *Cmd)

\r

len = param_getstr(Cmd,nameParamNo,filename);\r

\r

- if (len > FILE_PATH_SIZE - 4) len = FILE_PATH_SIZE - 4;\r

+ if (len > FILE_PATH_SIZE - 5) len = FILE_PATH_SIZE - 5;\r

\r

fnameptr += len;\r

\r

@@ -1547,7 +1580,7 @@ int CmdHF14AMfESave(const char *Cmd)

\r

len = param_getstr(Cmd,nameParamNo,filename);\r

\r

- if (len > FILE_PATH_SIZE - 4) len = FILE_PATH_SIZE - 4;\r

+ if (len > FILE_PATH_SIZE - 5) len = FILE_PATH_SIZE - 5;\r

\r

// user supplied filename?\r

if (len < 1) {\r

@@ -1752,7 +1785,7 @@ int CmdHF14AMfCSetBlk(const char *Cmd)

{\r

uint8_t memBlock[16] = {0x00};\r

uint8_t blockNo = 0;\r

- bool wipeCard = FALSE;\r

+ bool wipeCard = false;\r

int res;\r

\r

if (strlen(Cmd) < 1 || param_getchar(Cmd, 0) == 'h') {\r

@@ -1823,7 +1856,7 @@ int CmdHF14AMfCLoad(const char *Cmd)

return 0;\r

} else {\r

len = strlen(Cmd);\r

- if (len > FILE_PATH_SIZE - 4) len = FILE_PATH_SIZE - 4;\r

+ if (len > FILE_PATH_SIZE - 5) len = FILE_PATH_SIZE - 5;\r

\r

memcpy(filename, Cmd, len);\r

fnameptr += len;\r

@@ -1864,6 +1897,7 @@ int CmdHF14AMfCLoad(const char *Cmd)

\r

if (mfCSetBlock(blockNum, buf8, NULL, 0, flags)) {\r

PrintAndLog("Can't set magic card block: %d", blockNum);\r

+ fclose(f);\r

return 3;\r

}\r

blockNum++;\r

@@ -1992,7 +2026,7 @@ int CmdHF14AMfCSave(const char *Cmd) {

return 0;\r

} else {\r

len = strlen(Cmd);\r

- if (len > FILE_PATH_SIZE - 4) len = FILE_PATH_SIZE - 4;\r

+ if (len > FILE_PATH_SIZE - 5) len = FILE_PATH_SIZE - 5;\r

\r

if (len < 1) {\r

// get filename\r

@@ -2112,11 +2146,14 @@ int CmdHF14AMfSniff(const char *Cmd){

uint16_t traceLen = resp.arg[1];\r

len = resp.arg[2];\r

\r

- if (res == 0) return 0; // we are done\r

+ if (res == 0) { // we are done\r

+ free(buf);\r

+ return 0;\r

+ }\r

\r

if (res == 1) { // there is (more) data to be transferred\r

if (pckNum == 0) { // first packet, (re)allocate necessary buffer\r

- if (traceLen > bufsize) {\r

+ if (traceLen > bufsize || buf == NULL) {\r

uint8_t *p;\r

if (buf == NULL) { // not yet allocated\r

p = malloc(traceLen);\r