FIX: CoverityScan 123358 and 133864 - Unchecked return value

[proxmark3-svn] / client / cmdlfviking.c

diff --git a/client/cmdlfviking.c b/client/cmdlfviking.c
index b91aced8eeb567738e24063cfd422f3668935f88..039e4ae6015a3bdd7a99a4a63df69d614f777d7a 100644 (file)
--- a/client/cmdlfviking.c
+++ b/client/cmdlfviking.c
@@ -47,9 +47,9 @@ int usage_lf_viking_sim(void) {
 
 // calc checksum
 uint64_t getVikingBits(uint32_t id) {
 
 // calc checksum
 uint64_t getVikingBits(uint32_t id) {

-       uint8_t checksum = (id>>24) ^ ((id>>16) & 0xFF) ^ ((id>>8) & 0xFF) ^ (id & 0xFF) ^ 0xF2 ^ 0xA8;
+       uint8_t checksum = ((id>>24) & 0xFF) ^ ((id>>16) & 0xFF) ^ ((id>>8) & 0xFF) ^ (id & 0xFF) ^ 0xF2 ^ 0xA8;

        uint64_t ret = (uint64_t)0xF2 << 56;
        uint64_t ret = (uint64_t)0xF2 << 56;

-       ret |= (id << 8);
+       ret |= (uint64_t)id << 8;

        ret     |= checksum;
        return ret;
 }
        ret     |= checksum;
        return ret;
 }