FIX: Coverity, resource leak, CID #121357, Mat needs to be free

[proxmark3-svn] / client / cmdhfmf.c

diff --git a/client/cmdhfmf.c b/client/cmdhfmf.c
index abc88b8621105bc089b723ec7b11a188bec67030..267f323cce9e551ca29374c2c2ffd70ac465a47b 100644 (file)
--- a/client/cmdhfmf.c
+++ b/client/cmdhfmf.c
@@ -988,6 +988,7 @@ int CmdHF14AMfChk(const char *Cmd)
                break;\r
        default:\r
                PrintAndLog("Key type must be A , B or ?");\r
                break;\r
        default:\r
                PrintAndLog("Key type must be A , B or ?");\r

+               free(keyBlock);\r

                return 1;\r
        };\r
        \r
                return 1;\r
        };\r
        \r


@@ -1039,6 +1040,7 @@ int CmdHF14AMfChk(const char *Cmd)
                                                if (!p) {\r
                                                        PrintAndLog("Cannot allocate memory for defKeys");\r
                                                        free(keyBlock);\r
                                                if (!p) {\r
                                                        PrintAndLog("Cannot allocate memory for defKeys");\r
                                                        free(keyBlock);\r

+                                                       free(f);\r

                                                        return 2;\r
                                                }\r
                                                keyBlock = p;\r
                                                        return 2;\r
                                                }\r
                                                keyBlock = p;\r


@@ -1224,10 +1226,10 @@ int CmdHF14AMf1kSim(const char *Cmd)
                                                corr_uid |= (uint64_t)data[2] << 48; \r
                                                corr_uid |= (uint64_t)data[1] << 40; \r
                                                corr_uid |= (uint64_t)data[0] << 32;\r
                                                corr_uid |= (uint64_t)data[2] << 48; \r
                                                corr_uid |= (uint64_t)data[1] << 40; \r
                                                corr_uid |= (uint64_t)data[0] << 32;\r

-                                               corr_uid |= data[7] << 24;\r
-                                               corr_uid |= data[6] << 16;\r
-                                               corr_uid |= data[5] << 8;\r
-                                               corr_uid |= data[4];\r
+                                               corr_uid |= (uint64_t)data[7] << 24;\r
+                                               corr_uid |= (uint64_t)data[6] << 16;\r
+                                               corr_uid |= (uint64_t)data[5] << 8;\r
+                                               corr_uid |= (uint64_t)data[4];\r

                                tryMfk64(corr_uid, data, key);\r
                                        }\r
                                        PrintAndLog("--");\r
                                tryMfk64(corr_uid, data, key);\r
                                        }\r
                                        PrintAndLog("--");\r