Merge pull request #494 from qaisjp/patch-1

[proxmark3-svn] / client / util.c

diff --git a/client/util.c b/client/util.c
index 8357f60137a5234007df335578656615e469cb65..92b0e7a6ab22dadd8160252f6364734b8c7a870d 100644 (file)
--- a/client/util.c
+++ b/client/util.c
@@ -154,6 +154,28 @@ char *sprint_hex(const uint8_t *data, const size_t len) {
        return buf;
 }
 
+char *sprint_hex_inrow_ex(const uint8_t *data, const size_t len, const size_t min_str_len) {
+       
+       int maxLen = ( len > 1024/2) ? 1024/2 : len;
+       static char buf[1024] = {0};
+       char *tmp = buf;
+       size_t i;
+
+       for (i = 0; i < maxLen; ++i, tmp += 2)
+               sprintf(tmp, "%02x", (unsigned int) data[i]);
+       
+       i *= 2;
+       int minStrLen = min_str_len > i ? min_str_len : 0;
+       for(; i < minStrLen; i++, tmp += 1) 
+               sprintf(tmp, " ");
+
+       return buf;
+}
+
+char *sprint_hex_inrow(const uint8_t *data, const size_t len) {
+       return sprint_hex_inrow_ex(data, len, 0);
+}
+
 char *sprint_bin_break(const uint8_t *data, const size_t len, const uint8_t breaks) {
        // make sure we don't go beyond our char array memory
        int max_len;
@@ -210,7 +232,7 @@ char *sprint_hex_ascii(const uint8_t *data, const size_t len) {
        return buf;
 }
 
-char *sprint_ascii(const uint8_t *data, const size_t len) {
+char *sprint_ascii_ex(const uint8_t *data, const size_t len, const size_t min_str_len) {
        static char buf[1024];
        char *tmp = buf;
        memset(buf, 0x00, 1024);
@@ -221,9 +243,18 @@ char *sprint_ascii(const uint8_t *data, const size_t len) {
                tmp[i] = ((c < 32) || (c == 127)) ? '.' : c;
                ++i;
        }
+       
+       int minStrLen = min_str_len > i ? min_str_len : 0;
+       for(; i < minStrLen; ++i) 
+               tmp[i] = ' ';
+       
        return buf;
 }
 
+char *sprint_ascii(const uint8_t *data, const size_t len) {
+       return sprint_ascii_ex(data, len, 0);
+}
+
 void num_to_bytes(uint64_t n, size_t len, uint8_t* dest)
 {
        while (len--) {
@@ -364,13 +395,19 @@ int param_getlength(const char *line, int paramnum)
        return en - bg + 1;
 }
 
-char param_getchar(const char *line, int paramnum)
-{
+char param_getchar(const char *line, int paramnum) {
+       return param_getchar_indx(line, 0, paramnum);
+}
+
+char param_getchar_indx(const char *line, int indx, int paramnum) {
        int bg, en;
        
        if (param_getptr(line, &bg, &en, paramnum)) return 0x00;
 
-       return line[bg];
+       if (bg + indx > en)
+               return '\0';
+       
+       return line[bg + indx];
 }
 
 uint8_t param_get8(const char *line, int paramnum)
@@ -480,11 +517,66 @@ int param_gethex_ex(const char *line, int paramnum, uint8_t * data, int *hexcnt)
 
        return 0;
 }
-int param_getstr(const char *line, int paramnum, char * str)
+
+int param_gethex_to_eol(const char *line, int paramnum, uint8_t * data, int maxdatalen, int *datalen) {
+       int bg, en;
+       uint32_t temp;
+       char buf[5] = {0};
+
+       if (param_getptr(line, &bg, &en, paramnum)) return 1;
+
+       *datalen = 0;
+       
+       int indx = bg;
+       while (line[indx]) {
+               if (line[indx] == '\t' || line[indx] == ' ') {
+                       indx++;
+                       continue;
+               }
+               
+               if (isxdigit(line[indx])) {
+                       buf[strlen(buf) + 1] = 0x00;
+                       buf[strlen(buf)] = line[indx];
+               } else {
+                       // if we have symbols other than spaces and hex
+                       return 1;
+               }                               
+
+               if (*datalen >= maxdatalen) {
+                       // if we dont have space in buffer and have symbols to translate
+                       return 2;
+               }
+
+               if (strlen(buf) >= 2) {
+                       sscanf(buf, "%x", &temp);
+                       data[*datalen] = (uint8_t)(temp & 0xff);
+                       *buf = 0;
+                       (*datalen)++;
+               }
+               
+               indx++;
+       }
+
+       if (strlen(buf) > 0) 
+               //error when not completed hex bytes
+               return 3;
+               
+       return 0;
+}
+
+int param_getstr(const char *line, int paramnum, char * str, size_t buffersize)
 {
        int bg, en;
 
-       if (param_getptr(line, &bg, &en, paramnum)) return 0;
+       if (param_getptr(line, &bg, &en, paramnum)) {   
+               return 0;
+       }
+
+       // Prevent out of bounds errors
+       if (en - bg + 1 >= buffersize) {
+               printf("out of bounds error: want %d bytes have %zd bytes\n", en - bg + 1 + 1, buffersize);
+               return 0;
+       }
        
        memcpy(str, line + bg, en - bg + 1);
        str[en - bg + 1] = 0;
@@ -502,6 +594,7 @@ https://github.com/ApertureLabsLtd/RFIDler/blob/master/firmware/Pic32/RFIDler.X/
 int hextobinarray(char *target, char *source)
 {
     int length, i, count= 0;
+    char* start = source;
     char x;
 
     length = strlen(source);
@@ -517,8 +610,10 @@ int hextobinarray(char *target, char *source)
             x -= '0';
         else if (x >= 'A' && x <= 'F')
             x -= 'A' - 10;
-        else
+        else {
+               printf("Discovered unknown character %c %d at idx %d of %s\n", x, x, source - start, start);
             return 0;
+        }
         // output
         for(i= 0 ; i < 4 ; ++i, ++count)
             *(target++)= (x >> (3 - i)) & 1;