Fix format-truncation warning, missing string.h inclusion and strnlen warning (#723)

[proxmark3-svn] / client / util.c

diff --git a/client/util.c b/client/util.c
index 4f84e3b5eed7b391ae31930fe35cd25f4893dbcd..423d14a08a80736c6e729fc6a4db51c5112dac08 100644 (file)
--- a/client/util.c
+++ b/client/util.c
@@ -16,6 +16,7 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include <time.h>
+#include <stdarg.h>
 
 #ifdef _WIN32
 #include <windows.h>
@@ -110,6 +111,35 @@ void FillFileNameByUID(char *fileName, uint8_t * uid, char *ext, int byteCount)
        sprintf(fnameptr, "%s", ext); 
 }
 
+// fill buffer from structure [{uint8_t data, size_t length},...]
+int FillBuffer(uint8_t *data, size_t maxDataLength, size_t *dataLength, ...) {
+       *dataLength = 0;
+       va_list valist;
+       va_start(valist, dataLength);
+       
+       uint8_t *vdata = NULL;
+       size_t vlength = 0;
+       do{
+               vdata = va_arg(valist, uint8_t *);
+               if (!vdata)
+                       break;
+               
+               vlength = va_arg(valist, size_t);
+               if (*dataLength + vlength >  maxDataLength) {
+                       va_end(valist);
+                       return 1;
+               }
+               
+               memcpy(&data[*dataLength], vdata, vlength);
+               *dataLength += vlength;
+               
+       } while (vdata);
+       
+       va_end(valist);
+
+       return 0;
+}
+
 void hex_to_buffer(const uint8_t *buf, const uint8_t *hex_data, const size_t hex_len, const size_t hex_max_len, 
        const size_t min_str_len, const size_t spaces_between, bool uppercase) {
                
@@ -138,35 +168,8 @@ void hex_to_buffer(const uint8_t *buf, const uint8_t *hex_data, const size_t hex
 
 // printing and converting functions
 
-void print_hex(const uint8_t * data, const size_t len)
-{
-       size_t i;
-
-       for (i=0; i < len; i++)
-               printf("%02x ", data[i]);
-
-       printf("\n");
-}
-
-void print_hex_break(const uint8_t *data, const size_t len, uint8_t breaks) {
-
-       int rownum = 0;
-       printf("[%02d] | ", rownum);
-       for (int i = 0; i < len; ++i) {
-
-               printf("%02X ", data[i]);
-               
-               // check if a line break is needed
-               if ( breaks > 0 && !((i+1) % breaks) && (i+1 < len) ) {
-                       ++rownum;
-                       printf("\n[%02d] | ", rownum);
-               }
-       }
-       printf("\n");
-}
-
 char *sprint_hex(const uint8_t *data, const size_t len) {
-       static char buf[1025] = {0};
+       static char buf[4097] = {0};
        
        hex_to_buffer((uint8_t *)buf, data, len, sizeof(buf) - 1, 0, 1, false);
 
@@ -174,7 +177,7 @@ char *sprint_hex(const uint8_t *data, const size_t len) {
 }
 
 char *sprint_hex_inrow_ex(const uint8_t *data, const size_t len, const size_t min_str_len) {
-       static char buf[1025] = {0};
+       static char buf[4097] = {0};
 
        hex_to_buffer((uint8_t *)buf, data, len, sizeof(buf) - 1, min_str_len, 0, false);
 
@@ -220,27 +223,6 @@ char *sprint_bin(const uint8_t *data, const size_t len) {
        return sprint_bin_break(data, len, 0);
 }
 
-char *sprint_hex_ascii(const uint8_t *data, const size_t len) {
-       static char buf[1024];
-       char *tmp = buf;
-       memset(buf, 0x00, 1024);
-       size_t max_len = (len > 255) ? 255 : len;
-       // max 255 bytes * 3 + 2 characters = 767 in buffer
-       sprintf(tmp, "%s| ", sprint_hex(data, max_len) );
-       
-       size_t i = 0;
-       size_t pos = (max_len * 3)+2;
-       // add another 255 characters ascii = 1020 characters of buffer used
-       while(i < max_len) {
-               char c = data[i];
-               if ( (c < 32) || (c == 127))
-                       c = '.';
-               sprintf(tmp+pos+i, "%c",  c);
-               ++i;
-       }
-       return buf;
-}
-
 char *sprint_ascii_ex(const uint8_t *data, const size_t len, const size_t min_str_len) {
        static char buf[1024];
        char *tmp = buf;
@@ -260,10 +242,6 @@ char *sprint_ascii_ex(const uint8_t *data, const size_t len, const size_t min_st
        return buf;
 }
 
-char *sprint_ascii(const uint8_t *data, const size_t len) {
-       return sprint_ascii_ex(data, len, 0);
-}
-
 void num_to_bytes(uint64_t n, size_t len, uint8_t* dest)
 {
        while (len--) {
@@ -324,16 +302,6 @@ uint8_t *SwapEndian64(const uint8_t *src, const size_t len, const uint8_t blockS
        return tmp;
 }
 
-// takes a uint8_t src array, for len items and reverses the byte order in blocksizes (8,16,32,64), 
-// returns: the dest array contains the reordered src array.
-void SwapEndian64ex(const uint8_t *src, const size_t len, const uint8_t blockSize, uint8_t *dest){
-       for (uint8_t block=0; block < (uint8_t)(len/blockSize); block++){
-               for (size_t i = 0; i < blockSize; i++){
-                       dest[i+(blockSize*block)] = src[(blockSize-1-i)+(blockSize*block)];
-               }
-       }
-}
-
 //assumes little endian
 char * printBits(size_t const size, void const * const ptr)
 {
@@ -648,17 +616,6 @@ int hextobinarray(char *target, char *source)
     return count;
 }
 
-// convert hex to human readable binary string
-int hextobinstring(char *target, char *source)
-{
-    int length;
-
-    if(!(length= hextobinarray(target, source)))
-        return 0;
-    binarraytobinstring(target, target, length);
-    return length;
-}
-
 // convert binary array of 0x00/0x01 values to hex (safe to do in place as target will always be shorter than source)
 // return number of bits converted
 int binarraytohex(char *target,char *source, int length)
@@ -681,16 +638,6 @@ int binarraytohex(char *target,char *source, int length)
     return length;
 }
 
-// convert binary array to human readable binary
-void binarraytobinstring(char *target, char *source,  int length)
-{
-    int i;
-
-    for(i= 0 ; i < length ; ++i)
-        *(target++)= *(source++) + '0';
-    *target= '\0';
-}
-
 // return parity bit required to match type
 uint8_t GetParity( uint8_t *bits, uint8_t type, int length)
 {
@@ -718,13 +665,6 @@ void xor(unsigned char *dst, unsigned char *src, size_t len) {
        *dst ^= *src;
 }
 
-int32_t le24toh (uint8_t data[3]) {
-    return (data[2] << 16) | (data[1] << 8) | data[0];
-}
-uint32_t le32toh (uint8_t *data) {
-       return (uint32_t)( (data[3]<<24) | (data[2]<<16) | (data[1]<<8) | data[0]);
-}
-
 // RotateLeft - Ultralight, Desfire, works on byte level
 // 00-01-02  >> 01-02-00
 void rol(uint8_t *data, const size_t len){