]> cvs.zerfleddert.de Git - proxmark3-svn/blobdiff - client/cmdhfmfu.c
FIX: made the authentication part a bit clearer. It now uses two booleans to seperat...
[proxmark3-svn] / client / cmdhfmfu.c
index 35e0d102d6c0454167ea50c65dd517e456d00fa3..667392809dadd109b61dd5b688ce1e97574dee12 100644 (file)
 #include "data.h"
 
 #define MAX_UL_BLOCKS          0x0f
-#define MAX_ULC_BLOCKS    0x2b
-#define MAX_ULEV1a_BLOCKS   0x12
-#define MAX_ULEV1b_BLOCKS      0x20
+#define MAX_ULC_BLOCKS         0x2b
+#define MAX_ULEV1a_BLOCKS      0x13
+#define MAX_ULEV1b_BLOCKS      0x28
+#define MAX_NTAG_203           0x29
+#define MAX_NTAG_210           0x13
+#define MAX_NTAG_212           0x28
 #define MAX_NTAG_213           0x2c
 #define MAX_NTAG_215           0x86
 #define MAX_NTAG_216        0xe6
@@ -32,7 +35,7 @@ uint8_t default_3des_keys[KEYS_3DES_COUNT][16] = {
                { 0x49,0x45,0x4D,0x4B,0x41,0x45,0x52,0x42,0x21,0x4E,0x41,0x43,0x55,0x4F,0x59,0x46 },// NFC-key
                { 0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x01 },// all ones
                { 0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF },// all FF
-               { 0x00,0x11,0x22,0x33,0x44,0x55,0x66,0x77,0x88,0x99,0xAA,0xBB,0xCC,0xDD,0xEE,0xFF },    // 11 22 33
+               { 0x00,0x11,0x22,0x33,0x44,0x55,0x66,0x77,0x88,0x99,0xAA,0xBB,0xCC,0xDD,0xEE,0xFF },// 11 22 33
        };
 
 #define KEYS_PWD_COUNT 10
@@ -51,12 +54,13 @@ uint8_t default_pwd_pack[KEYS_PWD_COUNT][4] = {
        {0x32,0x0C,0x16,0x17}, // PACK 0x80,0x80 -- AMiiboo (sniffed) 
 };     
        
-#define MAX_UL_TYPES 13
-uint16_t UL_TYPES_ARRAY[MAX_UL_TYPES] = {UNKNOWN, UL, UL_C, UL_EV1_48, UL_EV1_128, 
-           NTAG, NTAG_213, NTAG_215, NTAG_216, MY_D, MY_D_NFC, MY_D_MOVE, MY_D_MOVE_NFC};
-uint8_t UL_MEMORY_ARRAY[MAX_UL_TYPES] = {MAX_UL_BLOCKS, MAX_UL_BLOCKS, MAX_ULC_BLOCKS, 
-           MAX_ULEV1a_BLOCKS, MAX_ULEV1b_BLOCKS, MAX_NTAG_213, MAX_NTAG_213, MAX_NTAG_215,
-           MAX_NTAG_216, MAX_UL_BLOCKS, MAX_UL_BLOCKS, MAX_UL_BLOCKS, MAX_UL_BLOCKS};
+#define MAX_UL_TYPES 16
+uint16_t UL_TYPES_ARRAY[MAX_UL_TYPES] = {UNKNOWN, UL, UL_C, UL_EV1_48, UL_EV1_128, NTAG, NTAG_203,
+           NTAG_210, NTAG_212, NTAG_213, NTAG_215, NTAG_216, MY_D, MY_D_NFC, MY_D_MOVE, MY_D_MOVE_NFC};
+
+uint8_t UL_MEMORY_ARRAY[MAX_UL_TYPES] = {MAX_UL_BLOCKS, MAX_UL_BLOCKS, MAX_ULC_BLOCKS, MAX_ULEV1a_BLOCKS,
+           MAX_ULEV1b_BLOCKS, MAX_NTAG_203, MAX_NTAG_203, MAX_NTAG_210, MAX_NTAG_212, MAX_NTAG_213,
+           MAX_NTAG_215, MAX_NTAG_216, MAX_UL_BLOCKS, MAX_UL_BLOCKS, MAX_UL_BLOCKS, MAX_UL_BLOCKS};
 
 
 static int CmdHelp(const char *Cmd);
@@ -146,11 +150,16 @@ static int ul_select( iso14a_card_select_t *card ){
        ul_switch_on_field();
 
        UsbCommand resp;
-       if (!WaitForResponseTimeout(CMD_ACK, &resp, 1500)) return -1;
-       if (resp.arg[0] < 1) return -1;
+       bool ans = false;
+       ans = WaitForResponseTimeout(CMD_ACK, &resp, 1500);
+       if (!ans || resp.arg[0] < 1) {
+               PrintAndLog("iso14443a card select failed");
+               ul_switch_off_field();
+               return 0;
+       }
        
        memcpy(card, resp.d.asBytes, sizeof(iso14a_card_select_t));
-       return resp.arg[0];
+       return 1;
 }
 
 // This read command will at least return 16bytes.
@@ -293,14 +302,11 @@ static int ul_print_default( uint8_t *data){
 }
 
 static int ndef_print_CC(uint8_t *data) {
+       // no NDEF message
+       if(data[0] != 0xe1)
+               return -1;
 
-       PrintAndLog("\n--- NDEF Message");
-       
-       if(data[0] != 0xe1) {
-               PrintAndLog("no NDEF message");
-               return -1;              // no NDEF message
-       }
-
+       PrintAndLog("--- NDEF Message");
        PrintAndLog("Capability Container: %s", sprint_hex(data,4) );
        PrintAndLog("  %02X: NDEF Magic Number", data[0]); 
        PrintAndLog("  %02X: version %d.%d supported by tag", data[1], (data[1] & 0xF0) >> 4, data[1] & 0x0f);
@@ -318,7 +324,7 @@ static int ndef_print_CC(uint8_t *data) {
        return 0;                               
 }
 
-int ul_print_type(uint16_t tagtype, uint8_t spaces){
+int ul_print_type(uint32_t tagtype, uint8_t spaces){
        char spc[11] = "          ";
        spc[10]=0x00;
        char *spacer = spc + (10-spaces);
@@ -331,14 +337,24 @@ int ul_print_type(uint16_t tagtype, uint8_t spaces){
                PrintAndLog("%sTYPE : MIFARE Ultralight EV1 48bytes (MF0UL1101)", spacer); 
        else if ( tagtype & UL_EV1_128) 
                PrintAndLog("%sTYPE : MIFARE Ultralight EV1 128bytes (MF0UL2101)", spacer);
+       else if ( tagtype & NTAG )
+               PrintAndLog("%sTYPE : NTAG UNKNOWN", spacer);
        else if ( tagtype & NTAG_203 )
-               PrintAndLog("%sTYPE : NTAG 203 144bytes (NT2H0301G0DU)", spacer);
+               PrintAndLog("%sTYPE : NTAG 203 144bytes (NT2H0301F0DT)", spacer);
+       else if ( tagtype & NTAG_210 )
+               PrintAndLog("%sTYPE : NTAG 210 48bytes (NT2L1011G0DU)", spacer);
+       else if ( tagtype & NTAG_212 )
+               PrintAndLog("%sTYPE : NTAG 212 128bytes (NT2L1211G0DU)", spacer);
        else if ( tagtype & NTAG_213 )
                PrintAndLog("%sTYPE : NTAG 213 144bytes (NT2H1311G0DU)", spacer);
        else if ( tagtype & NTAG_215 )
                PrintAndLog("%sTYPE : NTAG 215 504bytes (NT2H1511G0DU)", spacer);
        else if ( tagtype & NTAG_216 )
                PrintAndLog("%sTYPE : NTAG 216 888bytes (NT2H1611G0DU)", spacer);
+       else if ( tagtype & NTAG_I2C_1K )
+               PrintAndLog("%sTYPE : NTAG I%sC 888bytes (NT3H1101FHK)", spacer, "\xFD");
+       else if ( tagtype & NTAG_I2C_2K )       
+               PrintAndLog("%sTYPE : NTAG I%sC 1904bytes (NT3H1201FHK)", spacer, "\xFD");
        else if ( tagtype & MY_D )
                PrintAndLog("%sTYPE : INFINEON my-d\x99", spacer);
        else if ( tagtype & MY_D_NFC )
@@ -348,7 +364,7 @@ int ul_print_type(uint16_t tagtype, uint8_t spaces){
        else if ( tagtype & MY_D_MOVE_NFC )
                PrintAndLog("%sTYPE : INFINEON my-d\x99 move NFC", spacer);
        else
-               PrintAndLog("%sTYPE : Unknown %04x", spacer, tagtype);
+               PrintAndLog("%sTYPE : Unknown %06x", spacer, tagtype);
        return 0;
 }
 
@@ -386,7 +402,7 @@ static int ulc_print_configuration( uint8_t *data){
 
 static int ulev1_print_configuration( uint8_t *data){
 
-       PrintAndLog("\n--- UL-EV1 Configuration");      
+       PrintAndLog("\n--- Tag Configuration");
 
        bool strg_mod_en = (data[0] & 2);
        uint8_t authlim = (data[4] & 0x07);
@@ -414,21 +430,24 @@ static int ulev1_print_configuration( uint8_t *data){
 }
 
 static int ulev1_print_counters(){
-       PrintAndLog("--- UL-EV1 Counters");
+       PrintAndLog("--- Tag Counters");
        uint8_t tear[1] = {0};
        uint8_t counter[3] = {0,0,0};
+       uint16_t len = 0;
        for ( uint8_t i = 0; i<3; ++i) {
                ulev1_readTearing(i,tear,sizeof(tear));
-               ulev1_readCounter(i,counter, sizeof(counter) );
+               len = ulev1_readCounter(i,counter, sizeof(counter) );
+               if (len == 3) {
                PrintAndLog("       [%0d] : %s", i, sprint_hex(counter,3));
                PrintAndLog("                    - %02X tearing %s", tear[0], ( tear[0]==0xBD)?"Ok":"failure");
        }
-       return 0;
+       }
+       return len;
 }
 
 static int ulev1_print_signature( uint8_t *data, uint8_t len){
-       PrintAndLog("\n--- UL-EV1 Signature");  
-       PrintAndLog("IC signature public key name  : NXP NTAG21x 2013");
+       PrintAndLog("\n--- Tag Signature");     
+       //PrintAndLog("IC signature public key name  : NXP NTAG21x 2013");  // don't know if there is other NXP public keys.. :(
        PrintAndLog("IC signature public key value : 04494e1a386d3d3cfe3dc10e5de68a499b1c202db5b132393e89ed19fe5be8bc61");
        PrintAndLog("    Elliptic curve parameters : secp128r1");
        PrintAndLog("            Tag ECC Signature : %s", sprint_hex(data, len));
@@ -438,7 +457,7 @@ static int ulev1_print_signature( uint8_t *data, uint8_t len){
 }
 
 static int ulev1_print_version(uint8_t *data){         
-       PrintAndLog("\n--- UL-EV1 / NTAG Version");
+       PrintAndLog("\n--- Tag Version");
        PrintAndLog("       Raw bytes : %s", sprint_hex(data, 8) );
        PrintAndLog("       Vendor ID : %02X, Manufacturer: %s", data[1], getTagInfo(data[1]));
        PrintAndLog("    Product type : %s"             , getProductTypeStr(data[2]));
@@ -463,9 +482,7 @@ static int ulc_magic_test(){
        uint8_t nonce1[11] = {0x00};
        uint8_t nonce2[11] = {0x00};
        int status = ul_select(&card);
-       if ( status < 1 ){
-               PrintAndLog("Error: couldn't select ulc_magic_test");
-               ul_switch_off_field();
+       if ( !status ){
                return UL_ERROR;
        }
        status = ulc_requestAuthentication(nonce1, sizeof(nonce1));
@@ -485,20 +502,17 @@ static int ul_magic_test(){
        // 1) take present UID, and try to write it back. OBSOLETE 
        // 2) make a wrong length write to page0, and see if tag answers with ACK/NACK:
        iso14a_card_select_t card;
-       int status = ul_select(&card);
-       if ( status < 1 ){
-               PrintAndLog("iso14443a card select failed");
-               ul_switch_off_field();
+       int status;
+       if ( !ul_select(&card) ) 
                return UL_ERROR;
-       }
        status = ul_comp_write(0, NULL, 0);
        ul_switch_off_field();
        if ( status == 0 ) 
-               return UL_MAGIC;
-       return UL;
+               return MAGIC;
+       return UNKNOWN;
 }
 
-uint16_t GetHF14AMfU_Type(void){
+uint32_t GetHF14AMfU_Type(void){
 
        TagTypeUL_t tagtype = UNKNOWN;
        iso14a_card_select_t card;
@@ -506,12 +520,8 @@ uint16_t GetHF14AMfU_Type(void){
        int status = 0;
        int len;
 
-       status = ul_select(&card);
-       if ( status < 1 ){
-               PrintAndLog("iso14443a card select failed");
-               ul_switch_off_field();
-               return UL_ERROR;
-       }
+       if (!ul_select(&card)) return UL_ERROR;
+
        // Ultralight - ATQA / SAK 
        if ( card.atqa[1] != 0x00 || card.atqa[0] != 0x44 || card.sak != 0x00 ) {
                PrintAndLog("Tag is not Ultralight | NTAG | MY-D  [ATQA: %02X %02X SAK: %02X]\n", card.atqa[1], card.atqa[0], card.sak);
@@ -531,12 +541,20 @@ uint16_t GetHF14AMfU_Type(void){
                                        tagtype = UL_EV1_48;
                                else if ( version[2] == 0x03 && version[6] != 0x0B ) 
                                        tagtype = UL_EV1_128;                                   
-                               else if ( version[2] == 0x04 && version[6] == 0x0F ) 
+                               else if ( version[2] == 0x04 && version[3] == 0x01 && version[6] == 0x0B )
+                                       tagtype = NTAG_210;
+                               else if ( version[2] == 0x04 && version[3] == 0x01 && version[6] == 0x0E )
+                                       tagtype = NTAG_212;
+                               else if ( version[2] == 0x04 && version[3] == 0x02 && version[6] == 0x0F )
                                        tagtype = NTAG_213;
-                               else if ( version[2] == 0x04 && version[6] == 0x11 ) 
+                               else if ( version[2] == 0x04 && version[3] == 0x02 && version[6] == 0x11 )
                                        tagtype = NTAG_215;     
-                               else if ( version[2] == 0x04 && version[6] == 0x13 ) 
-                                       tagtype = NTAG_216;
+                               else if ( version[2] == 0x04 && version[3] == 0x02 && version[6] == 0x13 )                              
+                                       tagtype = NTAG_216;                             
+                               else if ( version[2] == 0x04 && version[3] == 0x05 && version[6] == 0x13 )
+                                       tagtype = NTAG_I2C_1K;
+                               else if ( version[2] == 0x04 && version[3] == 0x05 && version[6] == 0x15 )
+                                       tagtype = NTAG_I2C_2K;
                                else if ( version[2] == 0x04 ) 
                                        tagtype = NTAG;
                                
@@ -544,39 +562,52 @@ uint16_t GetHF14AMfU_Type(void){
                                }
                        case 0x01: tagtype = UL_C; break;
                        case 0x00: tagtype = UL; break;
-                       case -1  : tagtype = (UL | UL_C); break;  //when does this happen?
+                       case -1  : tagtype = (UL | UL_C | NTAG_203); break;  //when does this happen?  -- if getversion fails, it assumes it is either UL/ULC -- but why? magic tags?
                        default  : tagtype = UNKNOWN; break;
                }
-               // UL-C test
-               if (tagtype == (UL | UL_C)) {
-                       status = ul_select(&card);
-                       if ( status < 1 ){
-                               PrintAndLog("iso14443a card select failed (UL-C)");
-                               ul_switch_off_field();
-                               return UL_ERROR;
-                       }
+               // UL vs UL-C vs ntag203 test
+               if (tagtype & (UL | UL_C | NTAG_203)) {
+                       if ( !ul_select(&card) ) return UL_ERROR;
+
+                       // do UL_C check first...
                        uint8_t nonce[11] = {0x00};
                        status = ulc_requestAuthentication(nonce, sizeof(nonce));
-                       tagtype = ( status > 0 ) ? UL_C : UL;
-
                        ul_switch_off_field();
+                       if (status > 1) {
+                               tagtype = UL_C;
+                       } else { 
+                               // need to re-select after authentication error
+                               if ( !ul_select(&card) ) return UL_ERROR;
+
+                               uint8_t data[16] = {0x00};
+                               // read page 0x26-0x29 (last valid ntag203 page)
+                               status = ul_read(0x26, data, sizeof(data));
+                               if ( status <= 1 ) {
+                                       tagtype = UL;
+                               } else {
+                                       // read page 0x30 (should error if it is a ntag203)
+                                       status = ul_read(30, data, sizeof(data));
+                                       if ( status <= 1 ){
+                                               tagtype = NTAG_203;
+                                       } else {
+                                               tagtype = UNKNOWN;
+                                       }
+                               }
+                               ul_switch_off_field();
+                       }
                }
-               
-               //NTAG203 detection here.
-               
        } else {
                // Infinition MY-D tests   Exam high nibble 
                uint8_t nib = (card.uid[1] & 0xf0) >> 4;
                switch ( nib ){
                        case 1: tagtype =  MY_D; break;
-                       case 2: tagtype = (MY_D | MY_D_NFC); break;
-                       case 3: tagtype = (MY_D_MOVE | MY_D_MOVE_NFC); break;
+                       case 2: tagtype = (MY_D | MY_D_NFC); break; //notice: we can not currently distinguish between these two
+                       case 3: tagtype = (MY_D_MOVE | MY_D_MOVE_NFC); break; //notice: we can not currently distinguish between these two
                }
        }
        
-       tagtype = (ul_magic_test() == UL_MAGIC) ? (tagtype | MAGIC) : tagtype;
-       //if ((tagtype & UL)) tagtype = ul_magic_test();
-
+       tagtype = (ul_magic_test() == MAGIC) ? (tagtype | MAGIC) : tagtype;
+       if (tagtype == (UNKNOWN | MAGIC)) tagtype = UL_MAGIC;
        return tagtype;
 }      
 
@@ -589,11 +620,13 @@ int CmdHF14AMfUInfo(const char *Cmd){
        int status;     
        bool errors = false;
        bool hasAuthKey = false;
+       bool hasPwdKey = false;
+       bool locked = false;
        uint8_t cmdp = 0;
        uint8_t datalen = 0;
        uint8_t authenticationkey[16] = {0x00};
        uint8_t pack[4] = {0,0,0,0};
-       int len=0;
+       int len = 0;
                                
        while(param_getchar(Cmd, cmdp) != 0x00)
        {
@@ -609,7 +642,7 @@ int CmdHF14AMfUInfo(const char *Cmd){
                        if ( !datalen ) {
                                memcpy(authenticationkey, data, 4);
                                cmdp += 2;
-                               hasAuthKey = true;
+                               hasPwdKey = true;
                                break;
                        }
                        // UL-C size key        
@@ -640,40 +673,42 @@ int CmdHF14AMfUInfo(const char *Cmd){
        PrintAndLog("-------------------------------------------------------------");
        ul_print_type(tagtype, 6);
        
+       if (!ul_select(&card)) return 0;
+       
        if ( hasAuthKey && (tagtype & UL_C)) {
                //will select card automatically and close connection on error
                if (!ulc_authentication(authenticationkey, false)) {
-                               PrintAndLog("Error: Authentication Failed UL-C");
-                               return 0;
-                       }
-               } else {
-               status = ul_select(&card);
-               if ( status < 1 ){
-                       PrintAndLog("iso14443a card select failed");
-                       ul_switch_off_field();
-                       return status;
-               }
-               if (hasAuthKey) {
-                       len = ulev1_requestAuthentication(authenticationkey, pack, sizeof(pack));
-                       if (len < 1) {
-                               ul_switch_off_field();
-                               PrintAndLog("Error: Authentication Failed UL-EV1/NTAG");
-                               return 0;
-                       }
+                       PrintAndLog("Error: Authentication Failed UL-C");
+                       return 0;
                }
        }
+       
+       if ( hasPwdKey ) {
+               len = ulev1_requestAuthentication(authenticationkey, pack, sizeof(pack));
+               if (len < 1) {
+                       ul_switch_off_field();
+                       PrintAndLog("Error: Authentication Failed UL-EV1/NTAG");
+                       return 0;
+               } 
+       }
 
-
-       // read pages 0,1,2,4 (should read 4pages)
+       // read pages 0,1,2,3 (should read 4pages)
        status = ul_read(0, data, sizeof(data));
        if ( status == -1 ){
                ul_switch_off_field();
                PrintAndLog("Error: tag didn't answer to READ");
                return status;
        }
+       
+       if (status == 16) {
+               ul_print_default(data);
+               ndef_print_CC(data+12);
+       }
+       else {
+               locked = true;
+       }
 
-       ul_print_default(data);
-
+       // UL_C Specific
        if ((tagtype & UL_C)){
        
                // read pages 0x28, 0x29, 0x2A, 0x2B
@@ -684,10 +719,11 @@ int CmdHF14AMfUInfo(const char *Cmd){
                        ul_switch_off_field();
                        return status;
                } 
-               ulc_print_configuration(ulc_conf);
+               if (status == 16) ulc_print_configuration(ulc_conf);
+               else locked = true;
 
                if ((tagtype & MAGIC)){
-
+                       //just read key
                        uint8_t ulc_deskey[16] = {0x00};
                        status = ul_read(0x2C, ulc_deskey, sizeof(ulc_deskey));
                        if ( status == -1 ){
@@ -695,7 +731,7 @@ int CmdHF14AMfUInfo(const char *Cmd){
                                PrintAndLog("Error: tag didn't answer to READ magic");
                                return status;
                        }
-                       ulc_print_3deskey(ulc_deskey);
+                       if (status == 16) ulc_print_3deskey(ulc_deskey);
 
                } else {
                        ul_switch_off_field();
@@ -707,21 +743,29 @@ int CmdHF14AMfUInfo(const char *Cmd){
                        for (uint8_t i = 0; i < KEYS_3DES_COUNT; ++i ){
                                key = default_3des_keys[i];
                                if (ulc_authentication(key, true)){
-                                       PrintAndLog("Found default 3des key: "); //%s", sprint_hex(key,16));
+                                       PrintAndLog("Found default 3des key: ");
                                        uint8_t keySwap[16];
                                        memcpy(keySwap, SwapEndian64(key,16,8), 16);
                                        ulc_print_3deskey(keySwap);
-                                       return 1;
-                               }
+                                       break;
+                               } 
                        }
-                       return 1; //return even if key not found (UL_C is done)
+                       // reselect for future tests (ntag test)
+                       if ( !ul_select(&card) ) return 0;
                }
        }
-       
+
+       // do counters and signature first (don't neet auth) 
+
+       // ul counters are different than ntag counters
        if ((tagtype & (UL_EV1_48 | UL_EV1_128))) {
+               if (ulev1_print_counters() != 3) {
+                       // failed - re-select
+                       if ( !ul_select(&card) ) return 0;
+               }
+       }
 
-               ulev1_print_counters();
-               
+       if ((tagtype & (UL_EV1_48 | UL_EV1_128 | NTAG_213 | NTAG_215 | NTAG_216 | NTAG_I2C_1K | NTAG_I2C_2K     ))) {
                uint8_t ulev1_signature[32] = {0x00};
                status = ulev1_readSignature( ulev1_signature, sizeof(ulev1_signature));
                if ( status == -1 ){
@@ -729,28 +773,14 @@ int CmdHF14AMfUInfo(const char *Cmd){
                        ul_switch_off_field();
                        return status;
                }               
-               ulev1_print_signature( ulev1_signature, sizeof(ulev1_signature));
-               
-               uint8_t startconfigblock = (tagtype & UL_EV1_48) ? 0x10 : 0x25;
-               uint8_t ulev1_conf[16] = {0x00};
-               status = ul_read(startconfigblock, ulev1_conf, sizeof(ulev1_conf));
-               if ( status == -1 ){
-                       PrintAndLog("Error: tag didn't answer to READ EV1");
-                       ul_switch_off_field();
-                       return status;
+               if (status == 32) ulev1_print_signature( ulev1_signature, sizeof(ulev1_signature));
+               else {
+                       // re-select
+                       if ( !ul_select(&card) ) return 0;
                }
-               // save AUTHENTICATION LIMITS for later:
-               authlim = (ulev1_conf[4] & 0x07);
-               bool allZeros = true;
-               for (uint8_t idx=0; idx<8; idx++)
-                       if (ulev1_conf[idx]) allZeros = false;
-
-               if (allZeros) authlim=7;
-               ulev1_print_configuration(ulev1_conf);
        }
        
-       if ((tagtype & (UL_EV1_48 | UL_EV1_128 | NTAG_213 | NTAG_215 | NTAG_216))) {
-
+       if ((tagtype & (UL_EV1_48 | UL_EV1_128 | NTAG_210 | NTAG_212 | NTAG_213 | NTAG_215 | NTAG_216 | NTAG_I2C_1K | NTAG_I2C_2K))) {
                uint8_t version[10] = {0x00};
                status  = ulev1_getVersion(version, sizeof(version));
                if ( status == -1 ){
@@ -758,14 +788,34 @@ int CmdHF14AMfUInfo(const char *Cmd){
                        ul_switch_off_field();
                        return status;
                }
-               ulev1_print_version(version);
+               if (status == 10) ulev1_print_version(version);
+               else locked = true;
 
+               uint8_t startconfigblock = 0;
+               uint8_t ulev1_conf[16] = {0x00};
+               // config blocks always are last 4 pages
+               for (uint8_t idx = 0; idx < MAX_UL_TYPES; idx++)
+                       if (tagtype & UL_TYPES_ARRAY[idx])
+                               startconfigblock = UL_MEMORY_ARRAY[idx]-3;
+
+               status = ul_read(startconfigblock, ulev1_conf, sizeof(ulev1_conf));
+               if ( status == -1 ) {
+                       PrintAndLog("Error: tag didn't answer to READ EV1");
+                       ul_switch_off_field();
+                       return status;
+               } else if (status == 16) {
+                       // save AUTHENTICATION LIMITS for later:
+                       authlim = (ulev1_conf[4] & 0x07);
+                       ulev1_print_configuration(ulev1_conf);
+               } else {
+                       authlim=7;
+               }
        
                // AUTHLIMIT, (number of failed authentications)
                // 0 = limitless.
                // 1-7 = limit. No automatic tries then.
                // hasAuthKey,  if we was called with key, skip test.
-               if ( authlim == 0 && !hasAuthKey ){
+               if ( !authlim && !hasAuthKey ) {
                        PrintAndLog("\n--- Known EV1/NTAG passwords.");
                        len = 0;
                        for (uint8_t i = 0; i < KEYS_PWD_COUNT; ++i ){
@@ -775,29 +825,15 @@ int CmdHF14AMfUInfo(const char *Cmd){
                                        PrintAndLog("Found a default password: %s || Pack: %02X %02X",sprint_hex(key, 4), pack[0], pack[1]);
                                        break;
                                } else {
-                                       status = ul_select(&card);
-                                       if ( status < 1 ){
-                                               PrintAndLog("iso14443a card select failed - ev1 auth");
-                                               ul_switch_off_field();
-                                               return status;
-                               }
+                                       if ( !ul_select(&card) ) return 0;
                        }
                        }
+                       if (len < 1) PrintAndLog("password not known");
                }
        }
-       
-       // NDEF Message
-       uint8_t cc[16] = {0x00};
-       status = ul_read(3, cc, sizeof(cc));
-       if ( status == -1 ){
-               PrintAndLog("Error: tag didn't answer to READ NDEF");
-               ul_switch_off_field();
-               return status;
-       }
-       ndef_print_CC(cc);
 
-       
        ul_switch_off_field();
+       if (locked) PrintAndLog("\nTag appears to be locked, try using the key to get more info");
        PrintAndLog("");
        return 1;
 }
@@ -1092,7 +1128,7 @@ int CmdHF14AMfUDump(const char *Cmd){
        }               
        
        // Load bottom lockbytes if available
-       // HOW DOES THIS APPLY TO EV1 and/or NTAG???
+       // TODO -- FIGURE OUT LOCK BYTES FOR TO EV1 and/or NTAG
        if ( Pages == 44 ) {
                lockbytes_t2 = data + (40*4);
                lockbytes2[0] = lockbytes_t2[2];
Impressum, Datenschutz