X-Git-Url: http://cvs.zerfleddert.de/cgi-bin/gitweb.cgi/proxmark3-svn/blobdiff_plain/081151eabb3728d4db4e5cca0cab2b2e397e3851..cd5767d43da36aa44a78bd4dcfbd7016349da3c6:/client/cmdlft55xx.c

diff --git a/client/cmdlft55xx.c b/client/cmdlft55xx.c
index 5804fbc7..513eb0ef 100644
--- a/client/cmdlft55xx.c
+++ b/client/cmdlft55xx.c
@@ -23,15 +23,16 @@
 
 
 #define LF_TRACE_BUFF_SIZE 12000 // 32 x 32 x 10  (32 bit times numofblock (7), times clock skip..)
+#define LF_BITSSTREAM_LEN 1000 // more then 1000 bits shouldn't happend..  8block * 4 bytes * 8bits = 
 static int CmdHelp(const char *Cmd);
 
 
 int CmdReadBlk(const char *Cmd)
 {
-	int Block = -1;
-	sscanf(Cmd, "%d", &Block);
+	int block = -1;
+	sscanf(Cmd, "%d", &block);
 
-	if ((Block > 7) | (Block < 0)) {
+	if ((block > 7) | (block < 0)) {
 		PrintAndLog("Block must be between 0 and 7");
 		return 1;
 	}	
@@ -40,7 +41,7 @@ int CmdReadBlk(const char *Cmd)
 	c.cmd = CMD_T55XX_READ_BLOCK;
 	c.d.asBytes[0] = 0x00;
 	c.arg[0] = 0;
-	c.arg[1] = Block;
+	c.arg[1] = block;
 	c.arg[2] = 0;
 	SendCommand(&c);
 	WaitForResponse(CMD_ACK, NULL);
@@ -55,7 +56,7 @@ int CmdReadBlk(const char *Cmd)
 	// }
 	// GraphTraceLen = LF_TRACE_BUFF_SIZE;
 	CmdSamples("12000");
-	ManchesterDemod(Block);
+	ManchesterDemod(block);
 	// RepaintGraphWindow();
   return 0;
 }
@@ -175,10 +176,10 @@ int CmdReadTrace(const char *Cmd)
 		GraphTraceLen = LF_TRACE_BUFF_SIZE;
 	}
 	
-	uint8_t bits[1000] = {0x00};
+	uint8_t bits[LF_BITSSTREAM_LEN] = {0x00};
 	uint8_t * bitstream = bits;
 	
-	manchester_decode(GraphBuffer, LF_TRACE_BUFF_SIZE, bitstream);
+	manchester_decode(GraphBuffer, LF_TRACE_BUFF_SIZE, bitstream, LF_BITSSTREAM_LEN);
 	RepaintGraphWindow();
 
 	uint8_t si = 5;
@@ -253,10 +254,10 @@ int CmdInfo(const char *Cmd){
 		CmdReadBlk("0");
 	}	
 
-	uint8_t bits[1000] = {0x00};
+	uint8_t bits[LF_BITSSTREAM_LEN] = {0x00};
 	uint8_t * bitstream = bits;
 	
-	manchester_decode(GraphBuffer, LF_TRACE_BUFF_SIZE, bitstream);
+	manchester_decode(GraphBuffer, LF_TRACE_BUFF_SIZE, bitstream, LF_BITSSTREAM_LEN);
 	
 	uint8_t si = 5;
 	uint32_t bl0      = PackBits(si, 32, bitstream);
@@ -306,26 +307,25 @@ int CmdDump(const char *Cmd){
 	char cmdp = param_getchar(Cmd, 0);
 	char s[20];
 	uint8_t pwd[4] = {0x00};
-		
-	if (strlen(Cmd)>1 || cmdp == 'h' || cmdp == 'H') {
+	bool hasPwd = ( strlen(Cmd) > 0);
+	
+	if ( cmdp == 'h' || cmdp == 'H') {
 		PrintAndLog("Usage:  lf t55xx dump <password>");
 		PrintAndLog("        sample: lf t55xx dump FFFFFFFF");
 		return 0;
 	}
-
-	bool hasPwd = ( strlen(Cmd) > 0);
 	
 	if ( hasPwd ){
-		if (param_gethex(Cmd, 0, pwd, 4)) {
-			PrintAndLog("password must include 4 HEX symbols");
+		if (param_gethex(Cmd, 0, pwd, 8)) {
+			PrintAndLog("password must include 8 HEX symbols");
 			return 0;
 		}
 	}
 
 	for ( int i = 0; i <8; ++i){
-		*s = 0;
+		memset(s,0,sizeof(s));
 		if ( hasPwd ) {
-			sprintf(s,"%d %d", i, pwd);
+			sprintf(s,"%d %02x%02x%02x%02x", i, pwd[0],pwd[1],pwd[2],pwd[3]);
 			CmdReadBlkPWD(s);
 		} else {
 			sprintf(s,"%d", i);
@@ -336,6 +336,9 @@ int CmdDump(const char *Cmd){
 }
 
 int CmdIceFsk(const char *Cmd){
+
+	if (!HasGraphData()) return 0;
+
 	iceFsk3(GraphBuffer, LF_TRACE_BUFF_SIZE);
 	RepaintGraphWindow();
 	return 0;
@@ -344,16 +347,17 @@ int CmdIceManchester(const char *Cmd){
 	ManchesterDemod( -1);
 	return 0;
 }
-int ManchesterDemod(int block){
+int ManchesterDemod(int blockNum){
 
-	int  blockNum = -1;
+	if (!HasGraphData()) return 0;
+		
 	uint8_t sizebyte = 32;
 	uint8_t offset = 5;
 	uint32_t blockData;
-	uint8_t  bits[1000] = {0x00};
+	uint8_t  bits[LF_BITSSTREAM_LEN] = {0x00};
 	uint8_t * bitstream = bits;
 	
-	manchester_decode(GraphBuffer, LF_TRACE_BUFF_SIZE, bitstream);	
+	manchester_decode(GraphBuffer, LF_TRACE_BUFF_SIZE, bitstream, LF_BITSSTREAM_LEN);	
     blockData = PackBits(offset, sizebyte, bitstream);
 
 	if ( blockNum < 0)
@@ -478,8 +482,8 @@ static command_t CommandTable[] =
   {"rdpwd",  CmdReadBlkPWD,  0, "<block> <password> -- Read T55xx block data with password mode"},
   {"wr",     CmdWriteBlk,    0, "<data> <block> -- Write T55xx block data (page 0)"},
   {"wrpwd",  CmdWriteBlkPWD, 0, "<data> <block> <password> -- Write T55xx block data with password"},
-  {"trace",  CmdReadTrace,   0, "[1] Read T55xx traceability data (page 1 / blk 0-1) "},
-  {"info",   CmdInfo,        0, "[1] Read T55xx configuration data (page0 /blk 0)"},
+  {"trace",  CmdReadTrace,   0, "[1] Read T55xx traceability data (page 1/ blk 0-1)"},
+  {"info",   CmdInfo,        0, "[1] Read T55xx configuration data (page 0/ blk 0)"},
   {"dump",   CmdDump,        0, "[password] Dump T55xx card block 0-7. optional with password"},
   {"fsk",    CmdIceFsk,      0, "FSK demod"},
   {"man",    CmdIceManchester,      0, "Manchester demod (with SST)"},