From: marshmellow42 Date: Sun, 14 Feb 2016 17:06:29 +0000 (-0500) Subject: FIX, Coverity, Argument can't be negative. CID# 212322, ftell(f) can … X-Git-Tag: v2.3.0~7^2~12 X-Git-Url: http://cvs.zerfleddert.de/cgi-bin/gitweb.cgi/proxmark3-svn/commitdiff_plain/7a616c0d70d3018c6bf81095f7432543a38ad3c9?ds=inline FIX, Coverity, Argument can't be negative. CID# 212322, ftell(f) can … …be negative. Not allowed in malloc... from @iceman1001 --- diff --git a/client/cmdhficlass.c b/client/cmdhficlass.c index 59b0ddc3..a169e827 100644 --- a/client/cmdhficlass.c +++ b/client/cmdhficlass.c @@ -283,8 +283,12 @@ int CmdHFiClassELoad(const char *Cmd) { long fsize = ftell(f); fseek(f, 0, SEEK_SET); - uint8_t *dump = malloc(fsize); + if (fsize < 0) { + PrintAndLog("Error, when getting filesize"); + return 1; + } + uint8_t *dump = malloc(fsize); size_t bytes_read = fread(dump, 1, fsize, f); fclose(f);