From 354d3a33fd68a836328be1b41e63369f212045ce Mon Sep 17 00:00:00 2001 From: "martin.holst@gmail.com" Date: Sat, 11 May 2013 12:22:11 +0000 Subject: [PATCH] Fixed another issue where a buffer was filled with 0x44, affecting chinese cards-commands. see http://www.proxmark.org/forum/viewtopic.php?id=1467&p=6 --- armsrc/mifarecmd.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/armsrc/mifarecmd.c b/armsrc/mifarecmd.c index dbf69f66..62e5188b 100644 --- a/armsrc/mifarecmd.c +++ b/armsrc/mifarecmd.c @@ -954,9 +954,13 @@ void MifareCGetBlock(uint32_t arg0, uint32_t arg1, uint32_t arg2, uint8_t *datai // if (isOK) memcpy(ack.d.asBytes, data, 18); // add trace trailer - memset(data, 0x44, 4); - LogTrace(data, 4, 0, 0, TRUE); - + /* + * Removed by Martin, this piece of overwrites the 'data' variable + * which is sent two lines down, and is obviously not correct. + * + * memset(data, 0x44, 4); + * LogTrace(data, 4, 0, 0, TRUE); + */ LED_B_ON(); cmd_send(CMD_ACK,isOK,0,0,data,18); // UsbSendPacket((uint8_t *)&ack, sizeof(UsbCommand)); -- 2.39.5