From 3b875041dc994ee4fefb788e8d1309b68baa4706 Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Wed, 11 Jan 2017 22:00:17 +0100 Subject: [PATCH] FIX: 'hf 14a reader' - when card SAK was 0x00, it calls GetHF14AMfU_Type() to try to identify if it is a UL/NTAG etc. The bug is that it ignored the return value. when return_value == UL_ERROR, it shall not print the mfu tagtype annotation. ---faulty behavior proxmark3> hf 14a reader UID : 65 93 7f d1 ATQA : 00 04 SAK : 00 [2] Tag is not Ultralight | NTAG | MY-D [ATQA: 00 04 SAK: 00] TYPE : MIFARE Ultralight (MF0ICU1) proprietary non iso14443-4 card found, RATS not supported Answers to chinese magic backdoor commands: NO --- client/cmdhf14a.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/client/cmdhf14a.c b/client/cmdhf14a.c index abb786f4..6411a919 100644 --- a/client/cmdhf14a.c +++ b/client/cmdhf14a.c @@ -216,16 +216,15 @@ int CmdHF14AReader(const char *Cmd) { ul_switch_off_field(); uint32_t tagT = GetHF14AMfU_Type(); - ul_print_type(tagT, 0); + if (tagT != UL_ERROR) + ul_print_type(tagT, 0); // reconnect for further tests c.arg[0] = ISO14A_CONNECT | ISO14A_NO_DISCONNECT; c.arg[1] = 0; c.arg[2] = 0; - clearCommandBuffer(); SendCommand(&c); - UsbCommand resp; WaitForResponse(CMD_ACK, &resp); -- 2.39.5