BUG: missing %s in printing version tagtype. Thanks @Marshmellow!

BUG: buffer overflow when reading the Capability Container.   Thanks @Marshmellow!

diff --git a/client/cmdhfmfu.c b/client/cmdhfmfu.c
index a9a178268395c6d1eab759c0d0ae998e063a1765..2e9ca4000900a1afe1e8f3322fe44d64a3d2e3a0 100644 (file)
--- a/client/cmdhfmfu.c
+++ b/client/cmdhfmfu.c
@@ -65,7 +65,7 @@ char* getProductTypeStr( uint8_t id){
                sprintf(retStr, "0x%02X %s", id, "(NTAG)");
                break;
        default:
                sprintf(retStr, "0x%02X %s", id, "(NTAG)");
                break;
        default:

-               sprintf(retStr, "0x%02X ", id, "(unknown)");
+               sprintf(retStr, "0x%02X %s", id, "(unknown)");

                break;
        }
        return buf;
                break;
        }
        return buf;


@@ -148,6 +148,7 @@ static int ul_select( iso14a_card_select_t *card ){
        return resp.arg[0];
 }
 
        return resp.arg[0];
 }
 

+// This read command will at least return 16bytes.

 static int ul_read( uint8_t page, uint8_t *response ){
        
        uint8_t cmd[] = {ISO14443A_CMD_READBLOCK, page};
 static int ul_read( uint8_t page, uint8_t *response ){
        
        uint8_t cmd[] = {ISO14443A_CMD_READBLOCK, page};


@@ -489,7 +490,7 @@ int CmdHF14AMfUInfo(const char *Cmd){
        if ((tagtype & (NTAG_213 | NTAG_215 | NTAG_216))){
                
                PrintAndLog("--- Trying some NTAG stuff");
        if ((tagtype & (NTAG_213 | NTAG_215 | NTAG_216))){
                
                PrintAndLog("--- Trying some NTAG stuff");

-               uint8_t cc[4] = {0x00};
+               uint8_t cc[16] = {0x00};

                status = ul_read(2, cc);
                if ( status == -1 ){
                        PrintAndLog("Error: tag didn't answer to READ");
                status = ul_read(2, cc);
                if ( status == -1 ){
                        PrintAndLog("Error: tag didn't answer to READ");