]>
cvs.zerfleddert.de Git - proxmark3-svn/log
iceman [Tue, 12 Jan 2016 09:39:23 +0000 (10:39 +0100)]
ADD: created some build scripts for the CoverityScans
iceman1001 [Tue, 19 Jan 2016 21:25:34 +0000 (22:25 +0100)]
FIX: Coverity scan, forgot one fread ...
CHG: Syntax suger
iceman1001 [Tue, 19 Jan 2016 20:48:29 +0000 (21:48 +0100)]
ADD: Some instructions for configure CoverityScan using alternative compiler like the ARM-NONE-EABI-GCC
FIX: stupid clock() == -1 on systems who doesn't have it..
iceman1001 [Tue, 19 Jan 2016 19:55:55 +0000 (20:55 +0100)]
FIX: Coverity Scan, #if - else -#endif statement most likely one row row.
iceman1001 [Tue, 19 Jan 2016 19:28:29 +0000 (20:28 +0100)]
FIX: Coverity Scans, z_stream.opaque not initialized, use Z_NULL;
iceman1001 [Tue, 19 Jan 2016 19:26:19 +0000 (20:26 +0100)]
FIX: Coverity scan, complain on z_stream.opaque is not initialized. Google it,says use: Z_NULL
iceman1001 [Tue, 19 Jan 2016 18:52:01 +0000 (19:52 +0100)]
FIX: Coverity Scan warnings on not using the fread return value.
iceman1001 [Tue, 19 Jan 2016 18:33:23 +0000 (19:33 +0100)]
CHG: Syntax suger, space -> tabs. etc.
FIX: Coverity Scan says out-of-bounds, Increased the databuffer. Legic List command needs to be re-done.
iceman1001 [Tue, 19 Jan 2016 18:32:10 +0000 (19:32 +0100)]
FIX: Coverity Scan says fgetc() returns a INT,
iceman1001 [Tue, 19 Jan 2016 18:31:34 +0000 (19:31 +0100)]
CHG: syntax suger
iceman1001 [Tue, 19 Jan 2016 17:06:14 +0000 (18:06 +0100)]
REM: removed a print. The printing is done in the calling function.
iceman1001 [Tue, 19 Jan 2016 17:01:16 +0000 (18:01 +0100)]
CHG: Syncronized so all different parts uses the same implementation of Crapto1 v3.3
iceman1001 [Tue, 19 Jan 2016 16:23:36 +0000 (17:23 +0100)]
FIX: Coverity Scan resource leak
iceman1001 [Tue, 19 Jan 2016 16:22:18 +0000 (17:22 +0100)]
CHG: started to clean up the crapto1 imp in client/nonce2key/ folder.
iceman1001 [Tue, 19 Jan 2016 15:59:06 +0000 (16:59 +0100)]
CHG: minor change initializing array.
iceman1001 [Tue, 19 Jan 2016 15:58:07 +0000 (16:58 +0100)]
FIX: CoverityScan complains on getchar(), not reading the returning value
iceman1001 [Tue, 19 Jan 2016 15:32:29 +0000 (16:32 +0100)]
CHG: The nonce from "hf mf nested" is fixed to this one, why is that one selected? Why not just all zeros or ones?
iceman1001 [Tue, 19 Jan 2016 15:31:38 +0000 (16:31 +0100)]
CHG: Syntax suger
iceman1001 [Tue, 19 Jan 2016 15:29:49 +0000 (16:29 +0100)]
FIX: Coverity scan, remove a resource leak, wrong varible type.
iceman1001 [Tue, 19 Jan 2016 15:29:07 +0000 (16:29 +0100)]
REM: Removed #define llx PRIx64, all these defines are located in proxmark3.h
iceman1001 [Tue, 19 Jan 2016 15:26:37 +0000 (16:26 +0100)]
ADD: Wrote a little help text to the nonce2key tools.
iceman1001 [Tue, 19 Jan 2016 15:19:59 +0000 (16:19 +0100)]
CHG: Crapto1 v3.3 for the ARMSRC
iceman1001 [Tue, 19 Jan 2016 15:17:29 +0000 (16:17 +0100)]
CHG: Crapto1 v3.3 now with comments, and I've tried to unnest some loops.
iceman1001 [Mon, 18 Jan 2016 22:28:34 +0000 (23:28 +0100)]
ADD: another key found
iceman1001 [Sun, 17 Jan 2016 22:06:48 +0000 (23:06 +0100)]
FIX: the "make clean" for mfkey/Makefile now deletes the executables.
iceman1001 [Sun, 17 Jan 2016 22:00:50 +0000 (23:00 +0100)]
FIX: makeing sure the "make clean" now deletes the nonce2key.exe file.
iceman1001 [Sat, 16 Jan 2016 22:14:14 +0000 (23:14 +0100)]
ADD: a markdown file for the readme.txt file. I want to be able to show the build status from TravisCI and Coverity Scans
iceman1001 [Sat, 16 Jan 2016 22:05:21 +0000 (23:05 +0100)]
CHG: Reversed @piwi 's changes to parity. I'm getting assembler compiler errors.
iceman1001 [Sat, 16 Jan 2016 22:04:19 +0000 (23:04 +0100)]
ADD: added the "llu" macro shortcut as format specifier.
iceman1001 [Sat, 16 Jan 2016 22:02:54 +0000 (23:02 +0100)]
CHG: changed output for the "hf mf nested" to show KEY: A or B instead of 0/1
iceman1001 [Sat, 16 Jan 2016 22:02:04 +0000 (23:02 +0100)]
FIX: Coverity fix with resource leakage
ADD: Implemented a addon to "hf mf nested" if there is KEY_A 's found but not the same KEY_B, try just read it from tag.
Makes the command a bit slower when it does these reads. Plus some annoying debug statements,
CHG: changed the output for "hf mf nested" to write Key A or B instead of 0 & 1..
iceman1001 [Sat, 16 Jan 2016 21:58:44 +0000 (22:58 +0100)]
FIX: Coverity Scan fixes, a bunch of them.
iceman1001 [Sat, 16 Jan 2016 16:49:45 +0000 (17:49 +0100)]
CHG: Updated the crapto1 imp to latest vesion3.3 ( Thanks @blapost !)
iceman1001 [Fri, 15 Jan 2016 20:47:32 +0000 (21:47 +0100)]
FIX: forgot a lua object for the call to ConvertAsciiToHex. Thanks @romaric for finding it.
iceman1001 [Fri, 15 Jan 2016 15:32:38 +0000 (16:32 +0100)]
CHG: lets see if I can get the perl script to work if I request "git fetch --all" before running the make command in Travis-CI
iceman1001 [Fri, 15 Jan 2016 14:22:25 +0000 (15:22 +0100)]
FIX: one of these days I will start being more observant about argument order
iceman1001 [Fri, 15 Jan 2016 11:53:13 +0000 (12:53 +0100)]
FIX: wrong format specifier syntax
iceman1001 [Fri, 15 Jan 2016 11:45:15 +0000 (12:45 +0100)]
ADD: some clocking for 'hf mf mifare', 'hf mf nested', 'hf mf chk'
iceman1001 [Fri, 15 Jan 2016 11:43:56 +0000 (12:43 +0100)]
REM: removed a dublett at end of file.
iceman1001 [Fri, 15 Jan 2016 11:43:29 +0000 (12:43 +0100)]
FIX: this should remove some warnings while compiling on linux and when running Travis-CI in a docker container.
some format specifier for uint64_t
and getting the git history in the perl script.
iceman1001 [Wed, 13 Jan 2016 21:24:12 +0000 (22:24 +0100)]
CHG: Tried to unfold some loops inside ARM/crypto1 imp. It can't hurt, feels stabil.
iceman1001 [Wed, 13 Jan 2016 20:51:47 +0000 (21:51 +0100)]
FIX: Some <= fix for pwpivi 's hardnested suggested on the Pm3 forum.
iceman1001 [Wed, 13 Jan 2016 20:51:06 +0000 (21:51 +0100)]
CHG: Tested to unfold some loops inside the crypto1 implementation to see if it generates some speed ups. Feels ok.
iceman1001 [Wed, 13 Jan 2016 13:53:32 +0000 (14:53 +0100)]
FIX: Coverity, out-of-bounds read, 124 is less than (0x10*8)+2 (130)
FIX: Coverity, dead-code, bitcomparison always false. Copy-paste error? but 0x0F can never be equal 0x10.. I guessing its 0x01. @pwpivi have to correct me if its wrong.
iceman1001 [Wed, 13 Jan 2016 13:51:02 +0000 (14:51 +0100)]
FIX: Coverity, out-of-bounds read ...
iceman1001 [Wed, 13 Jan 2016 12:22:25 +0000 (13:22 +0100)]
FIX: Coverity, resource leak, and variable can't be negative,
iceman1001 [Wed, 13 Jan 2016 12:15:34 +0000 (13:15 +0100)]
FIX: GCC 4.8 complains the pointer is set before its used in a call to free(). Doesn't complain on Mingw, only Ubuntu.15.10
iceman1001 [Wed, 13 Jan 2016 11:58:10 +0000 (12:58 +0100)]
FIX: Coverity, strlen(Cmd) can never be lesser than zero.. *douh*
iceman1001 [Wed, 13 Jan 2016 11:50:18 +0000 (12:50 +0100)]
FIX: Coverity, resource leaks 'nd more.. in "lf t55xx bruteforce" nasty piece of code...
iceman1001 [Wed, 13 Jan 2016 11:49:21 +0000 (12:49 +0100)]
FIX: forgot to change a modified call from @pwpivi 's last update.
iceman1001 [Wed, 13 Jan 2016 08:31:13 +0000 (09:31 +0100)]
ADD: @pwpiwi 's latest changes to 'hf mf hardnested'
iceman1001 [Tue, 12 Jan 2016 23:24:37 +0000 (00:24 +0100)]
REM: Removed lot of obselete code from before.
iceman1001 [Tue, 12 Jan 2016 23:16:11 +0000 (00:16 +0100)]
ADD: "lf hid bruteforce" for a simple bruteforce attact against a HID reader. *work in progress*
iceman1001 [Tue, 12 Jan 2016 23:14:08 +0000 (00:14 +0100)]
FIX: tcgetattr for Linux in Ukbhit(), should return -1 if fail.
iceman1001 [Tue, 12 Jan 2016 23:08:23 +0000 (00:08 +0100)]
FIX: Coverity, Unchecked return value, CID #121288, lets do the same check that is everywhere is this call is used.
iceman1001 [Tue, 12 Jan 2016 23:07:14 +0000 (00:07 +0100)]
FIX: Coverity, CID# 121351, #121371, #121372, old code that is not used any more, I should remove this.
iceman1001 [Tue, 12 Jan 2016 23:05:55 +0000 (00:05 +0100)]
FIX: textual changes
iceman1001 [Tue, 12 Jan 2016 22:56:15 +0000 (23:56 +0100)]
FIX: Coverity, resource leak, CID #121357, Mat needs to be free
iceman1001 [Tue, 12 Jan 2016 22:42:42 +0000 (23:42 +0100)]
FIX: Coverity, logical vs bitwise operator, remove the extra '&' for it to become bitwise.
iceman1001 [Tue, 12 Jan 2016 22:40:57 +0000 (23:40 +0100)]
FIX: Coverity, Unintended sign extension, data[7] would have become int, then uint64_t. Should work better now with adding typecasting.
iceman1001 [Tue, 12 Jan 2016 22:38:47 +0000 (23:38 +0100)]
FIX: Coverity, Resource leak, CID #121361, filehandle f needs to be free
iceman1001 [Tue, 12 Jan 2016 22:37:33 +0000 (23:37 +0100)]
FIX: Coverity, Resource leak, CID# 121360, keyBlock needs to be free
iceman1001 [Tue, 12 Jan 2016 22:35:06 +0000 (23:35 +0100)]
FIX: Coverity, out-of-bounds write, CID#121340, CID#121341, CID#121342, CID#121343, wrong size in check, sprintf always adds a null terminator, so if filepath would have been 996 chars long, this might had happend... but no more.
iceman1001 [Tue, 12 Jan 2016 22:29:05 +0000 (23:29 +0100)]
CHG: Syntax suger
iceman1001 [Tue, 12 Jan 2016 22:27:42 +0000 (23:27 +0100)]
FIX: Coverity, CID#121314, Explicit null dereferenced, in really odd occasions buf would be NULL, and sending NULL to memcpy dereferences it. Not sure about this fix.
iceman1001 [Tue, 12 Jan 2016 22:16:20 +0000 (23:16 +0100)]
FIX: Coverity, CID# 121337, Out-of-bounds. In the loop, variable i, can be as much as 1051, overflowing the databuf with size 1024.
iceman1001 [Tue, 12 Jan 2016 22:10:38 +0000 (23:10 +0100)]
FIX: Coverity, uninitialized scalar variable, filename array could be NULL..
iceman1001 [Tue, 12 Jan 2016 22:06:53 +0000 (23:06 +0100)]
FIX: Coverity, CID #121346, resouce leak, close filehandle.
iceman1001 [Tue, 12 Jan 2016 22:05:10 +0000 (23:05 +0100)]
FIX: Coverity, out-of-bounds, CID#121330, CID#121331, CID#121332, CID#121333,
keyNbr has to be smaller then ICLASS_KEYS_MAX (since the Iclass_Key_Table array is initialised with it).
iceman1001 [Tue, 12 Jan 2016 21:57:23 +0000 (22:57 +0100)]
FIX: Coverity, Dereference null return, CID #212329, filehandle could be NULL
iceman1001 [Tue, 12 Jan 2016 21:53:13 +0000 (22:53 +0100)]
FIX, Coverity, Unsigned compared against 0. CID #212326, keyNBr will never be negative.
iceman1001 [Tue, 12 Jan 2016 21:49:29 +0000 (22:49 +0100)]
FIX, Coverity, Argument can't be negative, CID #212324, ftell(f) can be negative, not allowed in malloc.
iceman1001 [Tue, 12 Jan 2016 21:47:48 +0000 (22:47 +0100)]
FIX: Coverity , Argument can't be negative, CID #121323, ftell(f) can be negative, not allowed in malloc.
FIX: forgot to close the filehandle :(
iceman1001 [Tue, 12 Jan 2016 21:43:28 +0000 (22:43 +0100)]
FIX, Coverity, Argument can't be negative. CID# 212322, ftell(f) can be negative. Not allowed in malloc...
iceman1001 [Tue, 12 Jan 2016 21:42:31 +0000 (22:42 +0100)]
CHG: syntax suger
iceman1001 [Tue, 12 Jan 2016 21:37:35 +0000 (22:37 +0100)]
FIX: Coverity, Identical code for different branches, CID #121315, added a message and different return value.
iceman1001 [Tue, 12 Jan 2016 21:33:54 +0000 (22:33 +0100)]
FIX: Coverity, unintended sign extention, CID #121363, (numbits << 16) becomes int, then uint64_t. But the signness might set all upper bits to 1 in the process.
iceman1001 [Tue, 12 Jan 2016 21:30:22 +0000 (22:30 +0100)]
FIX: Coverity, unchecked return value, CID #121292,..
basicallty the flush queue commmand is replaced with clearCommandBuffer();.
iceman1001 [Tue, 12 Jan 2016 21:15:49 +0000 (22:15 +0100)]
FIX: Coverity, out-of-bounds write, CID# 121336, s_index should take factor in consideration when looping. Not sure about this one.
FIX: another thing struck me, the g_index wasn't increased, meaning the "un-decimation" always worked on the same first byte of GraphBuffer.
iceman1001 [Sat, 9 Jan 2016 16:20:58 +0000 (17:20 +0100)]
Merge branch 'master' of https://github.com/iceman1001/proxmark3
iceman1001 [Sat, 9 Jan 2016 16:20:06 +0000 (17:20 +0100)]
FIX: minor fixes to the HID wiegand generation command. Still not complete
iceman1001 [Sat, 9 Jan 2016 16:19:09 +0000 (17:19 +0100)]
CHG: syntax suger
iceman1001 [Sat, 9 Jan 2016 16:17:36 +0000 (17:17 +0100)]
ADD: a new pwdgen algo Nicknamed C, (Huge props to @Bettse for everything) also added to the "hf mfu info" command. However, that will not work given the system's lockbits.. :( Maybe I'll add a function to test all imp pwdgens given a UID without making a authentication call to tag.
ADD: BSWAP_32 macro, for changing endianness.
iceman1001 [Sat, 9 Jan 2016 16:13:54 +0000 (17:13 +0100)]
ADD: Travis now builds automatically.
Iceman [Fri, 8 Jan 2016 21:40:02 +0000 (22:40 +0100)]
Update README.txt
iceman1001 [Fri, 8 Jan 2016 21:30:36 +0000 (22:30 +0100)]
fix: gcc-arm-none-eabi still not working...
iceman1001 [Fri, 8 Jan 2016 21:27:09 +0000 (22:27 +0100)]
ADD: added gcc-arm-none-eabi compiler to travie script
iceman1001 [Fri, 8 Jan 2016 21:18:15 +0000 (22:18 +0100)]
CHG: added the make command
iceman1001 [Fri, 8 Jan 2016 21:14:22 +0000 (22:14 +0100)]
ADD: added integration with Travis CI,
iceman1001 [Fri, 8 Jan 2016 14:29:06 +0000 (15:29 +0100)]
FIX: @marshmellow42 's cleanup of includes.
iceman1001 [Fri, 8 Jan 2016 14:28:24 +0000 (15:28 +0100)]
FIX: coverty scan defects.
- bigbuf.c is comparision correct (iLen versus numofparity)
- cmdhfepa.c resourceleak, add a call to free
- cipherutils.c resourceleak, added calls to free
iceman1001 [Fri, 8 Jan 2016 13:31:27 +0000 (14:31 +0100)]
REM: code cleanup.
iceman1001 [Fri, 8 Jan 2016 13:30:56 +0000 (14:30 +0100)]
FIX: coverty scan, resourceleak in "hf mf sniff", added call to 'free' befor return.
FIX: coverty scan, overflow in "hf 14a raw", added an extra len check against USB_CMD_DATA_SIZE
iceman1001 [Fri, 8 Jan 2016 13:28:13 +0000 (14:28 +0100)]
ADD: @go_tus 's code to generate wiegand codes from FacilityCode/SiteCode and Cardnumber. Almost there, formatlength supported is 26,34,35,37,38,40,44,75,84, when its finised.
iceman1001 [Fri, 8 Jan 2016 13:26:35 +0000 (14:26 +0100)]
Syntax suger, making the code easier to read (for me at least)
iceman1001 [Fri, 8 Jan 2016 13:25:10 +0000 (14:25 +0100)]
FIX: coverty scan reveals some resourceleaks and overruns, which is supposed to be fixed now.
/armsrc/des.c overflow 7 instead of 6
/client/cmdlfhitag.c overflows traclen
/client/util.c sprint_bin_break overflows.
/client/cmdhficlass.c need to free memory after malloc.
ADD: RotateRight macro in util.h
Iceman [Fri, 8 Jan 2016 12:29:59 +0000 (13:29 +0100)]
Update README.txt
Iceman [Fri, 8 Jan 2016 12:29:01 +0000 (13:29 +0100)]
Update README.txt
Iceman [Fri, 8 Jan 2016 12:24:56 +0000 (13:24 +0100)]
Update README.txt
Iceman [Fri, 8 Jan 2016 12:22:05 +0000 (13:22 +0100)]
Update README.txt