Rationalized LED usage in 14443-B: LED D shows RF Field OK,

and LED A, B and C respectively show:
- Receiving from reader
- Transmitting to tag/reader
- Receiving from tag

Also, updated the snoop function to make full use of the DMA buffer, which removes (in my case) all the 'blew DMA buffer' issues.

Last, moved the compilation of iso1443.c to ARM mode (not thumb) to make it faster on my Linux gcc 4.3 version, otherwise the 'blew DMA buffer' issue was systematic.

Also: restored the "indalademod" command which had mysteriously disappeared from the prox.exe (proxmark3) client!

diff --git a/armsrc/Makefile.linux b/armsrc/Makefile.linux
index 98c9c38609a609af467709c9b0c458b467e33986..f0d9325acd5d13997f3f8baf0a0b2a97a447b07f 100644 (file)
--- a/armsrc/Makefile.linux
+++ b/armsrc/Makefile.linux
@@ -31,11 +31,12 @@ OBJ =       $(OBJDIR)/start.o \
                $(OBJDIR)/appmain.o \
                $(OBJDIR)/fpga.o \
                $(OBJDIR)/iso15693.o \
-               $(OBJDIR)/iso14443.o \
                $(OBJDIR)/util.o
 
-
-OBJFAST =      $(OBJDIR)/iso14443a.o
+# To be compiled in ARM mode, not thumb mode: larger but faster
+# Alleviates the 'blew circular buffer' issues somehow...
+OBJFAST = $(OBJDIR)/iso14443.o \
+                 $(OBJDIR)/iso14443a.o
 
 OBJFPGA =      $(OBJDIR)/fpgaimg.o
 

diff --git a/armsrc/appmain.c b/armsrc/appmain.c
index a0bb00d35039cd69a83e03a55566e7cc7fd7b036..3cbe5c4f07558d251c729f19798c2606e2318f03 100644 (file)
--- a/armsrc/appmain.c
+++ b/armsrc/appmain.c
@@ -8,8 +8,8 @@
 \r
 #include <proxmark3.h>\r
 #include "apps.h"\r
-#include "fonts.h"\r
 #ifdef WITH_LCD\r
+#include "fonts.h"\r
 #include "LCD.h"\r
 #endif\r
 \r
@@ -657,10 +657,9 @@ void UsbPacketReceived(BYTE *packet, int len)
                        break;\r
 \r
                case CMD_FPGA_MAJOR_MODE_OFF:           // ## FPGA Control\r
-                       LED_C_ON();\r
                        FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
                        SpinDelay(200);\r
-                       LED_C_OFF();\r
+                       LED_D_OFF(); // LED D indicates field ON or OFF\r
                        break;\r
 \r
                case CMD_DOWNLOAD_RAW_ADC_SAMPLES_125K:\r

diff --git a/armsrc/iso14443.c b/armsrc/iso14443.c
index 7271b9d07b02a6a565e0eafef6d77b5c3da98bc0..311254d9e55a7d93a69c50f6c7ff17e977a9657f 100644 (file)
--- a/armsrc/iso14443.c
+++ b/armsrc/iso14443.c
@@ -131,10 +131,20 @@ static struct {
     BYTE   *output;\r
 } Uart;\r
 \r
+/* Receive & handle a bit coming from the reader.\r
+ *\r
+ * LED handling:\r
+ * LED A -> ON once we have received the SOF and are expecting the rest.\r
+ * LED A -> OFF once we have received EOF or are in error state or unsynced\r
+ *\r
+ * Returns: true if we received a EOF\r
+ *          false if we are still waiting for some more\r
+ */\r
 static BOOL Handle14443UartBit(int bit)\r
 {\r
     switch(Uart.state) {\r
         case STATE_UNSYNCD:\r
+               LED_A_OFF();\r
             if(!bit) {\r
                 // we went low, so this could be the beginning\r
                 // of an SOF\r
@@ -154,6 +164,7 @@ static BOOL Handle14443UartBit(int bit)
                         Uart.posCnt = 0;\r
                         Uart.byteCnt = 0;\r
                         Uart.state = STATE_AWAITING_START_BIT;\r
+                        LED_A_ON(); // Indicate we got a valid SOF\r
                     } else {\r
                         // didn't stay down long enough\r
                         // before going high, error\r
@@ -186,6 +197,7 @@ static BOOL Handle14443UartBit(int bit)
                 Uart.bitCnt = 0;\r
                 Uart.shiftReg = 0;\r
                 Uart.state = STATE_RECEIVING_DATA;\r
+                LED_A_ON(); // Indicate we're receiving\r
             }\r
             break;\r
 \r
@@ -221,6 +233,7 @@ static BOOL Handle14443UartBit(int bit)
                     }\r
                 } else if(Uart.shiftReg == 0x000) {\r
                     // this is an EOF byte\r
+                       LED_A_OFF(); // Finished receiving\r
                     return TRUE;\r
                 } else {\r
                     // this is an error\r
@@ -245,6 +258,8 @@ static BOOL Handle14443UartBit(int bit)
             break;\r
     }\r
 \r
+    if (Uart.state == STATE_ERROR_WAIT) LED_A_OFF(); // Error\r
+\r
     return FALSE;\r
 }\r
 \r
@@ -264,6 +279,8 @@ static BOOL GetIso14443CommandFromReader(BYTE *received, int *len, int maxLen)
 \r
     // Set FPGA mode to "simulated ISO 14443 tag", no modulation (listen\r
     // only, since we are receiving, not transmitting).\r
+    // Signal field is off with the appropriate LED\r
+    LED_D_OFF();\r
     FpgaWriteConfWord(\r
        FPGA_MAJOR_MODE_HF_SIMULATOR | FPGA_HF_SIMULATOR_NO_MODULATION);\r
 \r
@@ -371,6 +388,8 @@ void SimulateIso14443Tag(void)
         if(respLen <= 0) continue;\r
 \r
         // Modulate BPSK\r
+        // Signal field is off with the appropriate LED\r
+        LED_D_OFF();\r
         FpgaWriteConfWord(\r
                FPGA_MAJOR_MODE_HF_SIMULATOR | FPGA_HF_SIMULATOR_MODULATE_BPSK);\r
         SSC_TRANSMIT_HOLDING = 0xff;\r
@@ -426,6 +445,17 @@ static struct {
     int     sumQ;\r
 } Demod;\r
 \r
+/*\r
+ * Handles reception of a bit from the tag\r
+ *\r
+ * LED handling:\r
+ * LED C -> ON once we have received the SOF and are expecting the rest.\r
+ * LED C -> OFF once we have received EOF or are unsynced\r
+ *\r
+ * Returns: true if we received a EOF\r
+ *          false if we are still waiting for some more\r
+ *
+ */\r
 static BOOL Handle14443SamplesDemod(int ci, int cq)\r
 {\r
     int v;\r
@@ -498,6 +528,7 @@ static BOOL Handle14443SamplesDemod(int ci, int cq)
                 if(Demod.posCount < 12) {\r
                     Demod.state = DEMOD_UNSYNCD;\r
                 } else {\r
+                       LED_C_ON(); // Got SOF\r
                     Demod.state = DEMOD_AWAITING_START_BIT;\r
                     Demod.posCount = 0;\r
                     Demod.len = 0;\r
@@ -557,6 +588,7 @@ static BOOL Handle14443SamplesDemod(int ci, int cq)
                         Demod.state = DEMOD_AWAITING_START_BIT;\r
                     } else if(s == 0x000) {\r
                         // This is EOF\r
+                       LED_C_OFF();\r
                         return TRUE;\r
                         Demod.state = DEMOD_UNSYNCD;\r
                     } else {\r
@@ -572,9 +604,16 @@ static BOOL Handle14443SamplesDemod(int ci, int cq)
             break;\r
     }\r
 \r
+    if (Demod.state == DEMOD_UNSYNCD) LED_C_OFF(); // Not synchronized...\r
     return FALSE;\r
 }\r
 \r
+/*\r
+ *  Demodulate the samples we received from the tag\r
+ *  weTx: set to 'TRUE' if we behave like a reader\r
+ *        set to 'FALSE' if we behave like a snooper\r
+ *  quiet: set to 'TRUE' to disable debug output
+ */\r
 static void GetSamplesFor14443Demod(BOOL weTx, int n, BOOL quiet)\r
 {\r
     int max = 0;\r
@@ -607,6 +646,8 @@ static void GetSamplesFor14443Demod(BOOL weTx, int n, BOOL quiet)
     lastRxCounter = DMA_BUFFER_SIZE;\r
     FpgaSetupSscDma((BYTE *)dmaBuf, DMA_BUFFER_SIZE);\r
 \r
+    // Signal field is ON with the appropriate LED:\r
+       if (weTx) LED_D_ON(); else LED_D_OFF();\r
     // And put the FPGA in the appropriate mode\r
     FpgaWriteConfWord(\r
        FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |\r
@@ -616,7 +657,6 @@ static void GetSamplesFor14443Demod(BOOL weTx, int n, BOOL quiet)
         int behindBy = lastRxCounter - PDC_RX_COUNTER(SSC_BASE);\r
         if(behindBy > max) max = behindBy;\r
 \r
-        LED_D_ON();\r
         while(((lastRxCounter-PDC_RX_COUNTER(SSC_BASE)) & (DMA_BUFFER_SIZE-1))\r
                     > 2)\r
         {\r
@@ -642,7 +682,6 @@ static void GetSamplesFor14443Demod(BOOL weTx, int n, BOOL quiet)
                 gotFrame = 1;\r
             }\r
         }\r
-        LED_D_OFF();\r
 \r
         if(samples > 2000) {\r
             break;\r
@@ -697,7 +736,11 @@ static void TransmitFor14443(void)
         SSC_TRANSMIT_HOLDING = 0xff;\r
     }\r
 \r
-    FpgaWriteConfWord(\r
+    // Signal field is ON with the appropriate Red LED\r
+       LED_D_ON();\r
+       // Signal we are transmitting with the Green LED\r
+       LED_B_ON();\r
+       FpgaWriteConfWord(\r
        FPGA_MAJOR_MODE_HF_READER_TX | FPGA_HF_READER_TX_SHALLOW_MOD);\r
 \r
     for(c = 0; c < 10;) {\r
@@ -727,6 +770,7 @@ static void TransmitFor14443(void)
         }\r
         WDT_HIT();\r
     }\r
+    LED_B_OFF(); // Finished sending\r
 }\r
 \r
 //-----------------------------------------------------------------------------\r
@@ -797,28 +841,30 @@ void AcquireRawAdcSamplesIso14443(DWORD parameter)
 \r
     // Make sure that we start from off, since the tags are stateful;\r
     // confusing things will happen if we don't reset them between reads.\r
-    LED_D_OFF();\r
     FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
+    LED_D_OFF();\r
     SpinDelay(200);\r
 \r
     SetAdcMuxFor(GPIO_MUXSEL_HIPKD);\r
     FpgaSetupSsc();\r
 \r
     // Now give it time to spin up.\r
+    // Signal field is on with the appropriate LED\r
+    LED_D_ON();\r
     FpgaWriteConfWord(\r
        FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ);\r
     SpinDelay(200);\r
 \r
     CodeIso14443bAsReader(cmd1, sizeof(cmd1));\r
     TransmitFor14443();\r
-    LED_A_ON();\r
+//    LED_A_ON();\r
     GetSamplesFor14443Demod(TRUE, 2000, FALSE);\r
-    LED_A_OFF();\r
+//    LED_A_OFF();\r
 }\r
 
 //-----------------------------------------------------------------------------\r
 // Read a SRI512 ISO 14443 tag.\r
-// 
+//
 // SRI512 tags are just simple memory tags, here we're looking at making a dump
 // of the contents of the memory. No anticollision algorithm is done, we assume
 // we have a single tag in the field.
@@ -839,6 +885,8 @@ void ReadSRI512Iso14443(DWORD parameter)
     FpgaSetupSsc();\r
 \r
     // Now give it time to spin up.\r
+    // Signal field is on with the appropriate LED\r
+    LED_D_ON();\r
     FpgaWriteConfWord(\r
        FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ);\r
     SpinDelay(200);\r
@@ -847,9 +895,9 @@ void ReadSRI512Iso14443(DWORD parameter)
     BYTE cmd1[] = { 0x06, 0x00, 0x97, 0x5b};\r
     CodeIso14443bAsReader(cmd1, sizeof(cmd1));\r
     TransmitFor14443();\r
-    LED_A_ON();\r
+//    LED_A_ON();\r
     GetSamplesFor14443Demod(TRUE, 2000,TRUE);\r
-    LED_A_OFF();\r
+//    LED_A_OFF();\r
 
     if (Demod.len == 0) {
        DbpString("No response from tag");
@@ -865,9 +913,9 @@ void ReadSRI512Iso14443(DWORD parameter)
     ComputeCrc14443(CRC_14443_B, cmd1, 2, &cmd1[2], &cmd1[3]);\r
     CodeIso14443bAsReader(cmd1, sizeof(cmd1));\r
     TransmitFor14443();\r
-    LED_A_ON();\r
+//    LED_A_ON();\r
     GetSamplesFor14443Demod(TRUE, 2000,TRUE);\r
-    LED_A_OFF();\r
+//    LED_A_OFF();\r
     if (Demod.len != 3) {
        DbpString("Expected 3 bytes from tag, got:");
        DbpIntegers(Demod.len,0x0,0x0);
@@ -891,9 +939,9 @@ void ReadSRI512Iso14443(DWORD parameter)
     ComputeCrc14443(CRC_14443_B, cmd1, 1 , &cmd1[1], &cmd1[2]);
     CodeIso14443bAsReader(cmd1, 3); // Only first three bytes for this one\r
     TransmitFor14443();\r
-    LED_A_ON();\r
+//    LED_A_ON();\r
     GetSamplesFor14443Demod(TRUE, 2000,TRUE);\r
-    LED_A_OFF();\r
+//    LED_A_OFF();\r
     if (Demod.len != 10) {
        DbpString("Expected 10 bytes from tag, got:");
        DbpIntegers(Demod.len,0x0,0x0);
@@ -922,9 +970,9 @@ void ReadSRI512Iso14443(DWORD parameter)
            ComputeCrc14443(CRC_14443_B, cmd1, 2, &cmd1[2], &cmd1[3]);\r
            CodeIso14443bAsReader(cmd1, sizeof(cmd1));\r
            TransmitFor14443();\r
-           LED_A_ON();\r
+//         LED_A_ON();\r
            GetSamplesFor14443Demod(TRUE, 2000,TRUE);\r
-           LED_A_OFF();
+//         LED_A_OFF();
            if (Demod.len != 6) { // Check if we got an answer from the tag
                DbpString("Expected 6 bytes from tag, got less...");
                return;
@@ -957,6 +1005,13 @@ void ReadSRI512Iso14443(DWORD parameter)
 // triggering so that we start recording at the point that the tag is moved\r
 // near the reader.\r
 //-----------------------------------------------------------------------------\r
+/*\r
+ * Memory usage for this function, (within BigBuf)\r
+ * 0-1023 : Demodulated samples receive (1024 bytes)\r
+ * 1024-1535 : Last Received command, 512 bytes (reader->tag)\r
+ * 1536-2047 : Last Received command, 512 bytes(tag->reader)\r
+ * 2048-2304 : DMA Buffer, 256 bytes (samples)
+ */\r
 void SnoopIso14443(void)\r
 {\r
     // We won't start recording the frames that we acquire until we trigger;\r
@@ -965,9 +1020,9 @@ void SnoopIso14443(void)
     BOOL triggered = FALSE;\r
 \r
     // The command (reader -> tag) that we're working on receiving.\r
-    BYTE *receivedCmd = (((BYTE *)BigBuf) + 1024);\r
+    BYTE *receivedCmd = (BYTE *)(BigBuf) + 1024;\r
     // The response (tag -> reader) that we're working on receiving.\r
-    BYTE *receivedResponse = (((BYTE *)BigBuf) + 1536);\r
+    BYTE *receivedResponse = (BYTE *)(BigBuf) + 1536;\r
 \r
     // As we receive stuff, we copy it from receivedCmd or receivedResponse\r
     // into trace, along with its length and other annotations.\r
@@ -975,8 +1030,7 @@ void SnoopIso14443(void)
     int traceLen = 0;\r
 \r
     // The DMA buffer, used to stream samples from the FPGA.\r
-//#   define DMA_BUFFER_SIZE 256\r
-    SBYTE *dmaBuf = ((SBYTE *)BigBuf) + 2048;\r
+    SBYTE *dmaBuf = (SBYTE *)(BigBuf) + 2048;\r
     int lastRxCounter;\r
     SBYTE *upTo;\r
     int ci, cq;\r
@@ -986,7 +1040,8 @@ void SnoopIso14443(void)
     // information in the trace buffer.\r
     int samples = 0;\r
 \r
-    memset(trace, 0x44, 1000);\r
+    // Initialize the trace buffer\r
+    memset(trace, 0x44, 1024);\r
 \r
     // Set up the demodulator for tag -> reader responses.\r
     Demod.output = receivedResponse;\r
@@ -1000,6 +1055,8 @@ void SnoopIso14443(void)
     Uart.state = STATE_UNSYNCD;\r
 \r
     // And put the FPGA in the appropriate mode\r
+    // Signal field is off with the appropriate LED\r
+    LED_D_OFF();\r
     FpgaWriteConfWord(\r
        FPGA_MAJOR_MODE_HF_READER_RX_XCORR | FPGA_HF_READER_RX_XCORR_848_KHZ |\r
        FPGA_HF_READER_RX_XCORR_SNOOP);\r
@@ -1010,17 +1067,15 @@ void SnoopIso14443(void)
     upTo = dmaBuf;\r
     lastRxCounter = DMA_BUFFER_SIZE;\r
     FpgaSetupSscDma((BYTE *)dmaBuf, DMA_BUFFER_SIZE);\r
-\r
-    LED_A_ON();\r
-\r
     // And now we loop, receiving samples.\r
     for(;;) {\r
-        int behindBy = (lastRxCounter - PDC_RX_COUNTER(SSC_BASE)) &\r
+       int behindBy = (lastRxCounter - PDC_RX_COUNTER(SSC_BASE)) &\r
                                 (DMA_BUFFER_SIZE-1);\r
         if(behindBy > maxBehindBy) {\r
             maxBehindBy = behindBy;\r
-            if(behindBy > 100) {\r
+            if(behindBy > (DMA_BUFFER_SIZE-2)) { // TODO: understand whether we can increase/decrease as we want or not?\r
                 DbpString("blew circular buffer!");\r
+                DbpIntegers(behindBy,0,0);\r
                 goto done;\r
             }\r
         }\r
@@ -1033,7 +1088,7 @@ void SnoopIso14443(void)
         if(upTo - dmaBuf > DMA_BUFFER_SIZE) {\r
             upTo -= DMA_BUFFER_SIZE;\r
             lastRxCounter += DMA_BUFFER_SIZE;\r
-            PDC_RX_NEXT_POINTER(SSC_BASE) = (DWORD)upTo;\r
+            PDC_RX_NEXT_POINTER(SSC_BASE) = (DWORD) upTo;\r
             PDC_RX_NEXT_COUNTER(SSC_BASE) = DMA_BUFFER_SIZE;\r
         }\r
 \r
@@ -1093,14 +1148,13 @@ void SnoopIso14443(void)
             if(traceLen > 1000) break;\r
 \r
             triggered = TRUE;\r
-            LED_A_OFF();\r
-            LED_B_ON();\r
 \r
             // And ready to receive another response.\r
             memset(&Demod, 0, sizeof(Demod));\r
             Demod.output = receivedResponse;\r
             Demod.state = DEMOD_UNSYNCD;\r
         }\r
+               WDT_HIT();\r
 \r
         if(BUTTON_PRESS()) {\r
             DbpString("cancelled");\r
@@ -1114,7 +1168,6 @@ void SnoopIso14443(void)
     DbpIntegers(Uart.byteCntMax, traceLen, 0x23);\r
 \r
 done:\r
+       LED_D_OFF();\r
     PDC_CONTROL(SSC_BASE) = PDC_RX_DISABLE;\r
-    LED_A_OFF();\r
-    LED_B_OFF();\r
 }\r

diff --git a/armsrc/iso14443a.c b/armsrc/iso14443a.c
index 0957d0514ab28f10574b51fcea703e1bab37291a..c5557d394ef1cb2e9f2c6fd00fd3004b1dd1e438 100644 (file)
--- a/armsrc/iso14443a.c
+++ b/armsrc/iso14443a.c
@@ -516,8 +516,8 @@ void SnoopIso14443a(void)
        #define RECV_RES_OFFSET         3096\r
        #define DMA_BUFFER_OFFSET       3160\r
        #define DMA_BUFFER_SIZE         4096\r
-       #define TRACE_LENGTH            3000    \r
-       \r
+       #define TRACE_LENGTH            3000\r
+\r
 //     #define RECV_CMD_OFFSET         2032    // original (working as of 21/2/09) values\r
 //     #define RECV_RES_OFFSET         2096    // original (working as of 21/2/09) values\r
 //     #define DMA_BUFFER_OFFSET       2160    // original (working as of 21/2/09) values\r
@@ -567,6 +567,8 @@ void SnoopIso14443a(void)
     Uart.state = STATE_UNSYNCD;\r
 \r
     // And put the FPGA in the appropriate mode\r
+    // Signal field is off with the appropriate LED\r
+    LED_D_OFF();\r
     FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_ISO14443A | FPGA_HF_ISO14443A_SNIFFER);\r
     SetAdcMuxFor(GPIO_MUXSEL_HIPKD);\r
 \r
@@ -841,6 +843,8 @@ static BOOL GetIso14443aCommandFromReader(BYTE *received, int *len, int maxLen)
 {\r
     // Set FPGA mode to "simulated ISO 14443 tag", no modulation (listen\r
     // only, since we are receiving, not transmitting).\r
+    // Signal field is off with the appropriate LED\r
+    LED_D_OFF();\r
     FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_ISO14443A | FPGA_HF_ISO14443A_TAGSIM_LISTEN);\r
 \r
     // Now run a `software UART' on the stream of incoming samples.\r
@@ -893,8 +897,8 @@ void SimulateIso14443aTag(int tagType, int TagUid)
 \r
 // my desfire\r
     static const BYTE response2[] = { 0x88, 0x04, 0x21, 0x3f, 0x4d }; // known uid - note cascade (0x88), 2nd byte (0x04) = NXP/Phillips\r
-   \r
-       \r
+\r
+\r
 // When reader selects us during cascade1 it will send cmd3\r
 //BYTE response3[] = { 0x04, 0x00, 0x00 }; // SAK Select (cascade1) successful response (ULTRALITE)\r
 BYTE response3[] = { 0x24, 0x00, 0x00 }; // SAK Select (cascade1) successful response (DESFire)\r
@@ -909,7 +913,7 @@ static const BYTE response2a[] = { 0x51, 0x48, 0x1d, 0x80, 0x84 }; //  uid - cas
 //BYTE response3a[] = { 0x00, 0x00, 0x00 }; // SAK Select (cascade2) successful response (ULTRALITE)\r
 BYTE response3a[] = { 0x20, 0x00, 0x00 }; // SAK Select (cascade2) successful response (DESFire)\r
 ComputeCrc14443(CRC_14443_A, response3a, 1, &response3a[1], &response3a[2]);\r
-    \r
+\r
 // When reader tries to authenticate\r
        // static const BYTE cmd5[] = { 0x60, 0x00, 0xf5, 0x7b };\r
     static const BYTE response5[] = { 0x00, 0x00, 0x00, 0x00 }; // Very random tag nonce\r
@@ -1434,8 +1438,10 @@ static BOOL GetIso14443aAnswerFromTag(BYTE *receivedResponse, int maxLen, int *s
        // buffer needs to be 512 bytes\r
        int c;\r
 \r
-       // Set FPGA mode to "simulated ISO 14443 tag", no modulation (listen\r
+       // Set FPGA mode to "reader listen mode", no modulation (listen\r
     // only, since we are receiving, not transmitting).\r
+    // Signal field is on with the appropriate LED\r
+    LED_D_ON();\r
     FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_ISO14443A | FPGA_HF_ISO14443A_READER_LISTEN);\r
 \r
     // Now get the answer from the card\r
@@ -1528,7 +1534,7 @@ void ReaderIso14443a(DWORD parameter)
        int traceLen = 0;\r
        int rsamples = 0;\r
 \r
-       memset(trace, 0x44, 2000);                              // was 2000 - tied to oter size chnages \r
+       memset(trace, 0x44, 2000);                              // was 2000 - tied to oter size chnages\r
        // setting it to 3000 causes no tag responses to be detected (2900 is ok)\r
        // setting it to 1000 causes no tag responses to be detected\r
 \r
@@ -1558,6 +1564,8 @@ void ReaderIso14443a(DWORD parameter)
        FpgaSetupSsc();\r
 \r
        // Start from off (no field generated)\r
+    // Signal field is off with the appropriate LED\r
+    LED_D_OFF();\r
     FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);\r
     SpinDelay(200);\r
 \r
@@ -1565,13 +1573,14 @@ void ReaderIso14443a(DWORD parameter)
     FpgaSetupSsc();\r
 \r
        // Now give it time to spin up.\r
+    // Signal field is on with the appropriate LED\r
+    LED_D_ON();\r
     FpgaWriteConfWord(FPGA_MAJOR_MODE_HF_ISO14443A | FPGA_HF_ISO14443A_READER_MOD);\r
        SpinDelay(200);\r
 \r
        LED_A_ON();\r
        LED_B_OFF();\r
        LED_C_OFF();\r
-       LED_D_OFF();\r
 \r
        int samples = 0;\r
        int tsamples = 0;\r
@@ -1684,7 +1693,7 @@ void ReaderIso14443a(DWORD parameter)
                traceLen += Demod.len;\r
                if(traceLen > TRACE_LENGTH) goto done;\r
 \r
-// OK we have selected at least at cascade 1, lets see if first byte of UID was 0x88 in \r
+// OK we have selected at least at cascade 1, lets see if first byte of UID was 0x88 in\r
 // which case we need to make a cascade 2 request and select - this is a long UID\r
                if (receivedAnswer[0] == 0x88)\r
                {\r
@@ -1759,14 +1768,7 @@ void ReaderIso14443a(DWORD parameter)
                traceLen += Demod.len;\r
                if(traceLen > TRACE_LENGTH) goto done;\r
 \r
-\r
-\r
-\r
-\r
-\r
-               }       \r
-\r
-               \r
+               }\r
 \r
                // Secondly compute the two CRC bytes at the end\r
                ComputeCrc14443(CRC_14443_A, cmd5, 2, &cmd5[2], &cmd5[3]);\r
@@ -1809,7 +1811,6 @@ done:
        LED_A_OFF();\r
        LED_B_OFF();\r
        LED_C_OFF();\r
-       LED_D_OFF();\r
        DbpIntegers(rsamples, 0xCC, 0xCC);\r
        DbpString("ready..");\r
 }\r

diff --git a/winsrc/command.cpp b/winsrc/command.cpp
index 9c4990a32349e2602c8908bc654018e8eed34b64..9599645d1faa9e3cddb206158258776578dd6fa4 100644 (file)
--- a/winsrc/command.cpp
+++ b/winsrc/command.cpp
@@ -805,7 +805,7 @@ static void CmdHi15demod(char *str)
 {\r
        // The sampling rate is 106.353 ksps/s, for T = 18.8 us\r
 \r
-       // SOF defined as \r
+       // SOF defined as\r
        // 1) Unmodulated time of 56.64us\r
        // 2) 24 pulses of 423.75khz\r
        // 3) logic '1' (unmodulated for 18.88us followed by 8 pulses of 423.75khz)\r
@@ -833,7 +833,7 @@ static void CmdHi15demod(char *str)
                 1,  1,  1,  1\r
        };\r
 \r
-       // EOF defined as \r
+       // EOF defined as\r
        // 1) logic '0' (8 pulses of 423.75khz followed by unmodulated for 18.88us)\r
        // 2) 24 pulses of 423.75khz\r
        // 3) Unmodulated time of 56.64us\r
@@ -1667,7 +1667,7 @@ static void Cmdmanchesterdemod(char *str) {
                                BitStream[bitidx++]=GraphBuffer[i-1];
                        } else {
                                // Error
-                               PrintToScrollback("Warning: Manchester decode error for pulse width detection.");                               
+                               PrintToScrollback("Warning: Manchester decode error for pulse width detection.");
                                PrintToScrollback("(too many of those messages mean either the stream is not Manchester encoded, or clock is wrong)");
                        }
                }
@@ -1909,6 +1909,7 @@ static struct {
        "hi14alist",            CmdHi14alist,0,         "list ISO 14443a history",                              // ## New list command\r
        "hiddemod",             CmdHiddemod,1,          "HID Prox Card II (not optimal)",\r
        "hidfskdemod",          CmdHIDdemodFSK,0,       "HID FSK demodulator",\r
+    "indalademod",          CmdIndalademod,0,         "demod samples for Indala",\r
        "askdemod",             Cmdaskdemod,1,          "Attempt to demodulate simple ASK tags",\r
        "hidsimtag",            CmdHIDsimTAG,0,         "HID tag simulator",\r
        "mandemod",             Cmdmanchesterdemod,1,   "Try a Manchester demodulation on a binary stream",\r